Paths

Table of Contentst

Differential D20442

Select the domain (X-axis range) for charts before pulling data
ClosedPublic
Actions

Authored by epriestley on Apr 17 2019, 1:09 PM.

Tags

None

Referenced Files

	F13050737: D20442.id48799.diff
	Fri, Apr 19, 3:10 AM

	F13050736: D20442.id48797.diff
	Fri, Apr 19, 3:10 AM

	F13050735: D20442.id48749.diff
	Fri, Apr 19, 3:10 AM

	F13050734: D20442.id.diff
	Fri, Apr 19, 3:10 AM

	Unknown Object (File)
	Thu, Apr 11, 9:29 AM

	Unknown Object (File)
	Thu, Apr 11, 4:17 AM

	Unknown Object (File)
	Thu, Apr 4, 6:42 PM

	Unknown Object (File)
	Wed, Mar 27, 1:59 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T13279: Build Charting for Facts

Commits

rP23d8f000f709: Select the domain (X-axis range) for charts before pulling data

Summary

Depends on D20441. Ref T13279. Currently, we pull all the data, then decide what the X-axis should look like.

Since users will reasonably want to do stuff like "show me march-april 2018" in the future, we need to move toward flipping this around so that we can support cases where the domain is specified by the user.

For actual chart functions (like "constant(3)" or "cos(x)"), we must also know the domain before we pull data, since there are an infinite number of places where we can evaluate the function "constant(3)".

See note in T13279 about continunity.

Test Plan

Screen Shot 2019-04-17 at 6.02.47 AM.png (861×976 px, 156 KB)

Diff Detail

Repository

Branch

chart6

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/fact/chart/PhabricatorFactChartFunction.php:127	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 22619
Build 31001: Run Core Tests
Build 31000: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 17 2019, 1:09 PM

Herald added a subscriber: yelirekim. · View Herald TranscriptApr 17 2019, 1:09 PM

Harbormaster completed remote builds in B22619: Diff 48749.Apr 17 2019, 1:10 PM

epriestley requested review of this revision.Apr 17 2019, 1:10 PM

epriestley added a child revision: D20443: Add chart functions "x()" and "constant(3)".Apr 17 2019, 2:04 PM

amckinley accepted this revision.Apr 17 2019, 11:00 PM

amckinley added inline comments.

src/applications/fact/controller/PhabricatorFactChartController.php
36	No `setYAxis`?
124–127	No `list($domain_min, $domain_max)`?

This revision is now accepted and ready to land.Apr 17 2019, 11:00 PM

epriestley added inline comments.Apr 18 2019, 8:07 PM

src/applications/fact/controller/PhabricatorFactChartController.php
36	What, you think I'm just made of axes over here? That axes grow on trees?

Small simplification.

Harbormaster completed remote builds in B22669: Diff 48797.Apr 18 2019, 8:09 PM

Closed by commit rP23d8f000f709: Select the domain (X-axis range) for charts before pulling data (authored by epriestley). · Explain WhyApr 18 2019, 8:11 PM

This revision was automatically updated to reflect the committed changes.

amckinley added inline comments.Apr 18 2019, 11:42 PM

src/applications/fact/controller/PhabricatorFactChartController.php
36

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

fact/

chart/

PhabricatorChartAxis.php

27 lines

	chart/
	function/

PhabricatorChartFunction.php

22 lines

PhabricatorFactChartFunction.php

31 lines

controller/

PhabricatorFactChartController.php

69 lines

function/

PhabricatorChartFunction.php

PhabricatorFactChartFunction.php

Diff 48749

src/__phutil_library_map__.php

Loading...

src/applications/fact/chart/PhabricatorChartAxis.php

Loading...

src/applications/fact/chart/PhabricatorChartFunction.php

Loading...

src/applications/fact/chart/PhabricatorFactChartFunction.php

Loading...

src/applications/fact/controller/PhabricatorFactChartController.php

Loading...

src/applications/fact/function/PhabricatorChartFunction.php

Loading...

src/applications/fact/function/PhabricatorFactChartFunction.php

Loading...