Page MenuHomePhabricator

Deprecate the "Commit is on autoclose/permanent branch" Herald "Commit" field
ClosedPublic

Authored by epriestley on Apr 15 2019, 4:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 1:08 PM
Unknown Object (File)
Mon, Mar 4, 9:38 PM
Unknown Object (File)
Fri, Mar 1, 5:08 AM
Unknown Object (File)
Feb 21 2024, 1:21 PM
Unknown Object (File)
Feb 15 2024, 1:58 AM
Unknown Object (File)
Feb 3 2024, 10:10 PM
Unknown Object (File)
Feb 3 2024, 10:10 PM
Unknown Object (File)
Feb 3 2024, 10:10 PM
Subscribers
None

Details

Summary

Depends on D20426. Ref T13277. The new behavior is to fire Herald only once a commit becomes reachable from a permanent ref (previously, an "Autoclose" branch).

That means that every "Commit" Herald rule implicitly has this field as a condition, and it no longer does anything.

Test Plan

Wrote a Herald rule, saw this as an option in the "Deprecated" section.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I guess it's not worth cleaning this up and removing the class + DB rows since it's just a no-op now and shouldn't bother anyone.

This revision is now accepted and ready to land.Apr 17 2019, 8:08 PM

I think it's probably worth cleaning up at some point -- there's another similar rule in T13041, too, that could do with cleanup at the same time. But it's low/no-cost to just leave it around for a while and let users mostly migrate away from it on their own, hopefully.

This revision was automatically updated to reflect the committed changes.