Page MenuHomePhabricator
Differential D20427

Deprecate the "Commit is on autoclose/permanent branch" Herald "Commit" field
ClosedPublic
Actions

Authored by epriestley on Apr 15 2019, 4:48 PM.
Tags
None
Referenced Files
F19039622: D20427.diff
Wed, Nov 26, 8:31 AM
F19019985: D20427.id.diff
Sun, Nov 23, 4:47 PM
F19015802: D20427.diff
Sun, Nov 23, 1:48 AM
F18997203: D20427.id.diff
Nov 20 2025, 10:40 AM
F18975082: D20427.id.diff
Nov 16 2025, 3:53 AM
F18946024: D20427.id.diff
Nov 11 2025, 7:22 PM
F18853640: D20427.diff
Oct 31 2025, 6:31 PM
F18845658: D20427.diff
Oct 29 2025, 1:46 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs"
Commits
rP9107c2e26208: Deprecate the "Commit is on autoclose/permanent branch" Herald "Commit" field
Summary

Depends on D20426. Ref T13277. The new behavior is to fire Herald only once a commit becomes reachable from a permanent ref (previously, an "Autoclose" branch).

That means that every "Commit" Herald rule implicitly has this field as a condition, and it no longer does anything.

Test Plan

Wrote a Herald rule, saw this as an option in the "Deprecated" section.

Diff Detail

Repository
rP Phabricator
Branch
autoclose11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22599
Build 30963: Run Core Tests
Build 30962: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 15 2019, 4:48 PM
Harbormaster completed remote builds in B22599: Diff 48729.Apr 15 2019, 4:49 PM
epriestley requested review of this revision.Apr 15 2019, 4:49 PM
epriestley added a child revision: D20428: When a commit appears as an ancestor of a permanent ref for the first time, run all import steps.Apr 15 2019, 5:04 PM
epriestley mentioned this in T13041: In Herald Commit rules, "Reviewer" and "On Autoclose Branch" have been deprecated.Apr 15 2019, 5:05 PM
amckinley accepted this revision.Apr 17 2019, 8:08 PM

I guess it's not worth cleaning this up and removing the class + DB rows since it's just a no-op now and shouldn't bother anyone.

This revision is now accepted and ready to land.Apr 17 2019, 8:08 PM
epriestley added a comment.Apr 17 2019, 8:14 PM

I think it's probably worth cleaning up at some point -- there's another similar rule in T13041, too, that could do with cleanup at the same time. But it's low/no-cost to just leave it around for a while and let users mostly migrate away from it on their own, hopefully.

Closed by commit rP9107c2e26208: Deprecate the "Commit is on autoclose/permanent branch" Herald "Commit" field (authored by epriestley). · Explain WhyApr 18 2019, 12:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
herald/
10 lines

Diff 48729

View Options

src/applications/diffusion/herald/DiffusionCommitAutocloseHeraldField.php

Loading...
Phabricator · Built by Phacility