Page MenuHomePhabricator

When query panels have more results, show a "View All Results" button at the bottom
ClosedPublic

Authored by epriestley on Mar 27 2019, 5:43 PM.
Tags
None
Referenced Files
F15536339: D20336.diff
Thu, Apr 24, 9:17 AM
F15465526: D20336.id48541.diff
Wed, Apr 2, 8:07 PM
F15439723: D20336.id48532.diff
Wed, Mar 26, 9:05 AM
F15439337: D20336.id48541.diff
Mar 26 2025, 7:03 AM
F15436561: D20336.id.diff
Mar 25 2025, 3:11 PM
F15433308: D20336.id48532.diff
Mar 24 2025, 10:34 PM
F15431131: D20336.diff
Mar 24 2025, 10:43 AM
F15407599: D20336.diff
Mar 18 2025, 6:36 PM
Subscribers
None

Details

Summary

Depends on D20335. Ref T13263. Ref T13272. See PHI854. Ref T9903.

Currently, we don't provide a clear indicator that a query panel is showing a partial result set (UI looks the same whether there are more results or not).

We also don't provide any way to get to the full result set (regardless of whether it is the same as the visible set or not) on tab panels, since they don't inherit the header buttons.

To (mostly) fix these problems, add a "View All Results" button at the bottom of the list if the panel shows only a subset of results.

Test Plan

Screen Shot 2019-03-27 at 10.38.57 AM.png (539×1 px, 87 KB)

Screen Shot 2019-03-27 at 10.39.07 AM.png (465×691 px, 66 KB)

Screen Shot 2019-03-27 at 10.40.10 AM.png (340×1 px, 45 KB)

Diff Detail

Repository
rP Phabricator
Branch
panel4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22403
Build 30654: Run Core Tests
Build 30653: arc lint + arc unit