Page MenuHomePhabricator

Don't enable the "ScopeEngine" or try to identify scope context for diffs without context
ClosedPublic

Authored by epriestley on Feb 20 2019, 1:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 15, 1:22 PM
Unknown Object (File)
Feb 11 2024, 1:46 PM
Unknown Object (File)
Feb 3 2024, 9:28 PM
Unknown Object (File)
Dec 25 2023, 9:19 PM
Unknown Object (File)
Dec 24 2023, 10:33 PM
Unknown Object (File)
Nov 30 2023, 12:03 AM
Unknown Object (File)
Nov 15 2023, 4:57 AM
Unknown Object (File)
Nov 9 2023, 9:34 AM
Subscribers
None

Details

Summary

Depends on D20197. Ref T13161. We currently try to build a "ScopeEngine" even for diffs with no context (e.g., git diff instead of git diff -U9999).

Since we don't have any context, we won't really be able to figure out anything useful about scopes. Also, since ScopeEngine is pretty strict about what it accepts, we crash.

In these cases, just don't build a ScopeEngine.

Test Plan

Viewed a diff I copy/pasted with git diff instead of an arc diff / git diff -U99999, got a sensible diff with no context instead of a fatal.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable