Page MenuHomePhabricator

Don't enable the "ScopeEngine" or try to identify scope context for diffs without context
ClosedPublic

Authored by epriestley on Feb 20 2019, 1:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 10:01 PM
Unknown Object (File)
Wed, Apr 24, 2:25 AM
Unknown Object (File)
Sun, Apr 21, 4:06 PM
Unknown Object (File)
Wed, Apr 17, 3:07 PM
Unknown Object (File)
Thu, Apr 11, 7:16 AM
Unknown Object (File)
Fri, Apr 5, 11:09 PM
Unknown Object (File)
Sun, Mar 31, 11:29 AM
Unknown Object (File)
Sun, Mar 31, 11:29 AM
Subscribers
None

Details

Summary

Depends on D20197. Ref T13161. We currently try to build a "ScopeEngine" even for diffs with no context (e.g., git diff instead of git diff -U9999).

Since we don't have any context, we won't really be able to figure out anything useful about scopes. Also, since ScopeEngine is pretty strict about what it accepts, we crash.

In these cases, just don't build a ScopeEngine.

Test Plan

Viewed a diff I copy/pasted with git diff instead of an arc diff / git diff -U99999, got a sensible diff with no context instead of a fatal.

Diff Detail

Repository
rP Phabricator
Branch
diff4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22082
Build 30164: Run Core Tests
Build 30163: arc lint + arc unit