Differential D20043

Allow MFA enrollment guidance to be customized
ClosedPublic
Actions

Authored by epriestley on Jan 28 2019, 5:28 PM.

Tags

None

Referenced Files

	F14398861: D20043.diff
	Sun, Dec 22, 3:08 PM

	Unknown Object (File)
	Wed, Dec 11, 9:55 PM

	Unknown Object (File)
	Fri, Dec 6, 11:14 PM

	Unknown Object (File)
	Thu, Nov 28, 6:36 AM

	Unknown Object (File)
	Sat, Nov 23, 8:26 PM

	Unknown Object (File)
	Nov 20 2024, 1:39 AM

	Unknown Object (File)
	Nov 15 2024, 5:41 PM

	Unknown Object (File)
	Nov 12 2024, 8:18 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13242: 2019 Week 5 Bonus Content

Commits

rP70b474e550b7: Allow MFA enrollment guidance to be customized

Summary

Depends on D20039. Ref T13242. If installs want users to install a specific application, reference particular help, etc., let them customize the MFA enrollment message so they can make it say "if you have issues, see this walkthrough on the corporate wiki" or whatever.

Test Plan

Screen Shot 2019-01-28 at 9.27.01 AM.png (995×1 px, 236 KB)

Screen Shot 2019-01-28 at 9.21.59 AM.png (970×1 px, 217 KB)

Screen Shot 2019-01-28 at 9.24.07 AM.png (855×1 px, 153 KB)

Diff Detail

Repository

Branch

mfa10

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21712
Build 29624: Run Core Tests
Build 29623: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 28 2019, 5:28 PM

Harbormaster completed remote builds in B21712: Diff 47858.Jan 28 2019, 5:30 PM

epriestley requested review of this revision.Jan 28 2019, 5:30 PM

amckinley accepted this revision.Jan 29 2019, 3:15 AM

This revision is now accepted and ready to land.Jan 29 2019, 3:15 AM

Closed by commit rP70b474e550b7: Allow MFA enrollment guidance to be customized (authored by epriestley). · Explain WhyJan 30 2019, 2:22 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

auth/

application/

PhabricatorAuthApplication.php

2 lines

controller/

mfa/

PhabricatorAuthFactorProviderMessageController.php

84 lines

PhabricatorAuthFactorProviderViewController.php

18 lines

storage/

PhabricatorAuthFactorProvider.php

8 lines

xaction/

PhabricatorAuthFactorProviderEnrollMessageTransaction.php

39 lines

settings/

panel/

PhabricatorMultiFactorSettingsPanel.php

7 lines

Diff 47858

src/__phutil_library_map__.php

Loading...

src/applications/auth/application/PhabricatorAuthApplication.php

Loading...

src/applications/auth/controller/mfa/PhabricatorAuthFactorProviderMessageController.php

Loading...

src/applications/auth/controller/mfa/PhabricatorAuthFactorProviderViewController.php

Loading...

src/applications/auth/storage/PhabricatorAuthFactorProvider.php

Loading...

src/applications/auth/xaction/PhabricatorAuthFactorProviderEnrollMessageTransaction.php

Loading...

src/applications/settings/panel/PhabricatorMultiFactorSettingsPanel.php

Loading...