Page MenuHomePhabricator
Differential D20034

Add more factor details to the Settings factor list
ClosedPublic
Actions

Authored by epriestley on Jan 25 2019, 5:52 PM.
Tags
None
Referenced Files
F15539274: D20034.diff
Fri, Apr 25, 12:22 AM
F15504924: D20034.id.diff
Mon, Apr 14, 10:33 PM
F15501848: D20034.id47843.diff
Sun, Apr 13, 10:07 PM
F15467349: D20034.diff
Thu, Apr 3, 2:08 PM
F15338169: D20034.id.diff
Mar 9 2025, 9:38 AM
Unknown Object (File)
Feb 23 2025, 9:32 PM
Unknown Object (File)
Feb 23 2025, 9:31 PM
Unknown Object (File)
Feb 20 2025, 12:07 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13222: 2018 Week 48-51 Bonus Content
Commits
rPbce44385e1e3: Add more factor details to the Settings factor list
Summary

Depends on D20033. Ref T13222. Flesh this UI out a bit, and provide bit-strength information for TOTP.

Also, stop users from adding multiple SMS factors since this is pointless (they all always text your primary contact number).

Test Plan

Screen Shot 2019-01-25 at 9.46.49 AM.png (252×1 px, 51 KB)

Screen Shot 2019-01-25 at 9.49.53 AM.png (386×610 px, 41 KB)

Diff Detail

Repository
rP Phabricator
Branch
mfa4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21697
Build 29595: Run Core Tests
Build 29594: arc lint + arc unit

Revision Contents
Changeset List

Diff 47843

View Options

src/applications/auth/factor/PhabricatorAuthFactor.php

Loading...
View Options

src/applications/auth/factor/PhabricatorSMSAuthFactor.php

Loading...
View Options

src/applications/auth/factor/PhabricatorTOTPAuthFactor.php

Loading...
View Options

src/applications/auth/storage/PhabricatorAuthFactorProvider.php

Loading...
View Options

src/applications/settings/panel/PhabricatorMultiFactorSettingsPanel.php

Loading...
Phabricator · Built by Phacility