Page MenuHomePhabricator
Differential D19664

Don't show Phriction draft edit events in feed
ClosedPublic
Actions

Authored by epriestley on Sep 11 2018, 8:39 PM.
Tags
None
Referenced Files
F13952694: D19664.diff
Sun, Oct 13, 1:42 PM
Unknown Object (File)
Thu, Oct 10, 3:08 AM
Unknown Object (File)
Sun, Sep 29, 3:08 PM
Unknown Object (File)
Tue, Sep 24, 3:43 PM
Unknown Object (File)
Tue, Sep 24, 10:31 AM
Unknown Object (File)
Fri, Sep 20, 11:34 AM
Unknown Object (File)
Fri, Sep 20, 11:31 AM
Unknown Object (File)
Fri, Sep 20, 11:30 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13077: Plans: Phriction modern "v3" APIs, Drafts
Commits
rP0089ef4b60e3: Don't show Phriction draft edit events in feed
Summary

Depends on D19663. Ref T13077. When you edit a Phriction draft, don't publish a feed story. (The eventual "Publish" event gets a story.)

Test Plan

Made draft / non-draft / publish edits, only saw feed stories for non-draft and publish edits.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 11 2018, 8:39 PM
Harbormaster completed remote builds in B20797: Diff 46987.Sep 11 2018, 8:41 PM
epriestley requested review of this revision.Sep 11 2018, 8:41 PM
amckinley accepted this revision.Sep 12 2018, 7:21 PM
This revision is now accepted and ready to land.Sep 12 2018, 7:21 PM
Closed by commit rP0089ef4b60e3: Don't show Phriction draft edit events in feed (authored by epriestley). · Explain WhySep 12 2018, 8:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
phriction/
xaction/
4 lines

Diff 47003

View Options

src/applications/phriction/xaction/PhrictionDocumentDraftTransaction.php

Loading...
Phabricator · Built by Phacility