Differential D19664

Don't show Phriction draft edit events in feed
ClosedPublic
Actions

Authored by epriestley on Sep 11 2018, 8:39 PM.

Tags

None

Referenced Files

	F17508136: D19664.id46987.diff
	Thu, Jul 3, 1:11 AM

	Unknown Object (File)
	Wed, Jun 18, 9:52 PM

	Unknown Object (File)
	Fri, Jun 6, 6:13 AM

	Unknown Object (File)
	Thu, Jun 5, 7:42 PM

	Unknown Object (File)
	Jun 1 2025, 6:36 PM

	Unknown Object (File)
	Apr 30 2025, 4:37 AM

	Unknown Object (File)
	Apr 29 2025, 1:45 PM

	Unknown Object (File)
	Apr 28 2025, 9:55 PM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Maniphest Tasks

T13077: Plans: Phriction modern "v3" APIs, Drafts

Commits

rP0089ef4b60e3: Don't show Phriction draft edit events in feed

Summary

Depends on D19663. Ref T13077. When you edit a Phriction draft, don't publish a feed story. (The eventual "Publish" event gets a story.)

Test Plan

Made draft / non-draft / publish edits, only saw feed stories for non-draft and publish edits.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 11 2018, 8:39 PM

Harbormaster completed remote builds in B20797: Diff 46987.Sep 11 2018, 8:41 PM

epriestley requested review of this revision.Sep 11 2018, 8:41 PM

amckinley accepted this revision.Sep 12 2018, 7:21 PM

This revision is now accepted and ready to land.Sep 12 2018, 7:21 PM

Closed by commit rP0089ef4b60e3: Don't show Phriction draft edit events in feed (authored by epriestley). · Explain WhySep 12 2018, 8:56 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

xaction/

PhrictionDocumentDraftTransaction.php

4 lines

Diff 47003

View Options

src/applications/phriction/xaction/PhrictionDocumentDraftTransaction.php

Don't show Phriction draft edit events in feedClosedPublicActions