Page MenuHomePhabricator
Differential D19664

Don't show Phriction draft edit events in feed
ClosedPublic
Actions

Authored by epriestley on Sep 11 2018, 8:39 PM.
Tags
None
Referenced Files
F19044378: D19664.diff
Thu, Nov 27, 2:38 AM
F18877933: D19664.id.diff
Thu, Nov 6, 12:59 PM
F18876192: D19664.diff
Wed, Nov 5, 10:19 PM
F18834017: D19664.id47003.diff
Oct 26 2025, 6:50 AM
F18834016: D19664.id46987.diff
Oct 26 2025, 6:50 AM
F18834015: D19664.id.diff
Oct 26 2025, 6:50 AM
F18832483: D19664.diff
Oct 25 2025, 9:58 PM
F18832003: D19664.id.diff
Oct 25 2025, 6:07 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13077: Plans: Phriction modern "v3" APIs, Drafts
Commits
rP0089ef4b60e3: Don't show Phriction draft edit events in feed
Summary

Depends on D19663. Ref T13077. When you edit a Phriction draft, don't publish a feed story. (The eventual "Publish" event gets a story.)

Test Plan

Made draft / non-draft / publish edits, only saw feed stories for non-draft and publish edits.

Diff Detail

Repository
rP Phabricator
Branch
wiki6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20797
Build 28286: Run Core Tests
Build 28285: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 11 2018, 8:39 PM
Harbormaster completed remote builds in B20797: Diff 46987.Sep 11 2018, 8:41 PM
epriestley requested review of this revision.Sep 11 2018, 8:41 PM
amckinley accepted this revision.Sep 12 2018, 7:21 PM
This revision is now accepted and ready to land.Sep 12 2018, 7:21 PM
Closed by commit rP0089ef4b60e3: Don't show Phriction draft edit events in feed (authored by epriestley). · Explain WhySep 12 2018, 8:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
phriction/
xaction/
4 lines

Diff 46987

View Options

src/applications/phriction/xaction/PhrictionDocumentDraftTransaction.php

Loading...
Phabricator · Built by Phacility