Page MenuHomePhabricator
Differential D19664

Don't show Phriction draft edit events in feed
ClosedPublic
Actions

Authored by epriestley on Sep 11 2018, 8:39 PM.
Tags
None
Referenced Files
F14387542: D19664.diff
Sat, Dec 21, 2:51 PM
Unknown Object (File)
Tue, Dec 17, 3:49 AM
Unknown Object (File)
Oct 26 2024, 6:06 PM
Unknown Object (File)
Oct 20 2024, 11:09 PM
Unknown Object (File)
Oct 17 2024, 5:49 PM
Unknown Object (File)
Oct 13 2024, 1:42 PM
Unknown Object (File)
Oct 10 2024, 3:08 AM
Unknown Object (File)
Sep 29 2024, 3:08 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13077: Plans: Phriction modern "v3" APIs, Drafts
Commits
rP0089ef4b60e3: Don't show Phriction draft edit events in feed
Summary

Depends on D19663. Ref T13077. When you edit a Phriction draft, don't publish a feed story. (The eventual "Publish" event gets a story.)

Test Plan

Made draft / non-draft / publish edits, only saw feed stories for non-draft and publish edits.

Diff Detail

Repository
rP Phabricator
Branch
wiki6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20797
Build 28286: Run Core Tests
Build 28285: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 11 2018, 8:39 PM
Harbormaster completed remote builds in B20797: Diff 46987.Sep 11 2018, 8:41 PM
epriestley requested review of this revision.Sep 11 2018, 8:41 PM
amckinley accepted this revision.Sep 12 2018, 7:21 PM
This revision is now accepted and ready to land.Sep 12 2018, 7:21 PM
Closed by commit rP0089ef4b60e3: Don't show Phriction draft edit events in feed (authored by epriestley). · Explain WhySep 12 2018, 8:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
phriction/
xaction/
4 lines

Diff 46987

View Options

src/applications/phriction/xaction/PhrictionDocumentDraftTransaction.php

Loading...
Phabricator · Built by Phacility