Page MenuHomePhabricator

Make the data export format selector remember your last setting
ClosedPublic

Authored by epriestley on Jan 29 2018, 3:35 PM.
Tags
None
Referenced Files
F12835208: D18957.diff
Thu, Mar 28, 3:02 PM
Unknown Object (File)
Jan 21 2024, 7:55 PM
Unknown Object (File)
Jan 10 2024, 3:06 AM
Unknown Object (File)
Dec 21 2023, 11:09 PM
Unknown Object (File)
Dec 15 2023, 1:16 PM
Unknown Object (File)
Nov 30 2023, 4:01 AM
Unknown Object (File)
Nov 25 2023, 6:08 PM
Unknown Object (File)
Nov 16 2023, 10:14 PM
Subscribers
None

Details

Summary

Depends on D18956. Ref T13049. Make the "Export Format" selector sticky.

This is partly selfish, since it makes testing format changes a bit easier.

It also seems like it's probably a good behavior in general: if you export to Excel once, that's probably what you're going to pick next time.

Test Plan

Exported to excel. Exported again, got excel as the default option.

Diff Detail

Repository
rP Phabricator
Branch
export7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19240
Build 25996: Run Core Tests
Build 25995: arc lint + arc unit

Event Timeline

Cool that this is so easy!

This revision is now accepted and ready to land.Jan 29 2018, 9:32 PM

This could probably be wrapped in something to make it a little slimmer if we start doing more of it, but I think we only have ~2-3 places where we do this right now (the other one that springs to mind is that we save projects you've recently used to set policies in the policy control).

This revision was automatically updated to reflect the committed changes.