Differential D18939

Provide character position information to symbol queries
ClosedPublic
Actions

Authored by epriestley on Jan 26 2018, 2:34 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13047: Plans: Symbol Indexes

Commits

rPfdc36677ba4f: Provide character position information to symbol queries

Summary

Depends on D18937. Ref T13047. When available, provide character positions so external indexers can return more accurate results.

Test Plan

Clicked symbols in Safari, Firefox and Chrome, got sensible-looking character positions.

Diff Detail

Repository

rP Phabricator

Branch

symbol3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19195
Build 25930: Run Core Tests
Build 25929: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 26 2018, 2:34 PM

Harbormaster completed remote builds in B19195: Diff 45414.Jan 26 2018, 2:35 PM

epriestley requested review of this revision.Jan 26 2018, 2:35 PM

epriestley added a child revision: D18940: Fix an issue with symbol lookup identifying path names in Diffusion.Jan 26 2018, 2:45 PM

amckinley accepted this revision.Jan 26 2018, 8:36 PM

This revision is now accepted and ready to land.Jan 26 2018, 8:36 PM

Closed by commit rPfdc36677ba4f: Provide character position information to symbol queries (authored by epriestley). · Explain WhyJan 26 2018, 9:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

18 lines

src/

applications/

diffusion/

controller/

DiffusionSymbolController.php

7 lines

symbol/

DiffusionExternalSymbolQuery.php

10 lines

webroot/

rsrc/

js/

application/

repository/

repository-crossreference.js

44 lines

Diff 45414

View Options

resources/celerity/map.php

View Options

src/applications/diffusion/controller/DiffusionSymbolController.php

View Options

src/applications/diffusion/symbol/DiffusionExternalSymbolQuery.php

View Options

webroot/rsrc/js/application/repository/repository-crossreference.js

Provide character position information to symbol queriesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45414

resources/celerity/map.php

src/applications/diffusion/controller/DiffusionSymbolController.php

src/applications/diffusion/symbol/DiffusionExternalSymbolQuery.php

webroot/rsrc/js/application/repository/repository-crossreference.js

Provide character position information to symbol queries
ClosedPublic
Actions

Revision Contents
Changeset List