HomePhabricator

Add a "Revision status" field to Herald for Differential revisions

Description

Add a "Revision status" field to Herald for Differential revisions

Summary: See PHI280. We have a similar field for tasks already, this is generally a reasonable sort of thing to support, and the addition of "draft" states means there are some pretty reasonable use cases.

Test Plan:

  • Wrote a status-based ("status is needs revision") Herald rule.
  • Tested it against a "Needs Revision" revision (passed) and a "Changes Planned" revision (failed).

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D18938

Details

Provenance
epriestleyAuthored on Jan 26 2018, 3:36 AM
epriestleyPushed on Jan 26 2018, 9:01 PM
Reviewer
amckinley
Differential Revision
D18938: Add a "Revision status" field to Herald for Differential revisions
Parents
rPd606eb1c38b1: When available, pass path, line and repository hints to external symbol queries
Branches
Unknown
Tags
Unknown
Build Status
Buildable 19213
Build 25952: Run Core Tests