Page MenuHomePhabricator
Differential D18930

Implement an "only if the rule did not match last time" policy for Herald rules
ClosedPublic
Actions

Authored by epriestley on Jan 25 2018, 5:52 PM.
Tags
None
Referenced Files
F14406694: D18930.diff
Mon, Dec 23, 7:25 PM
Unknown Object (File)
Sat, Dec 21, 11:07 PM
Unknown Object (File)
Fri, Dec 13, 6:35 PM
Unknown Object (File)
Thu, Nov 28, 7:28 AM
Unknown Object (File)
Wed, Nov 27, 4:11 PM
Unknown Object (File)
Sun, Nov 24, 6:51 AM
Unknown Object (File)
Nov 14 2024, 4:05 AM
Unknown Object (File)
Nov 9 2024, 4:58 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald
Commits
rPa34b6bdd06b7: Implement an "only if the rule did not match last time" policy for Herald rules
Summary

Depends on D18927. Ref T13048. This implements a new policy which allows Herald rules to fire on some kinds of state changes.

Test Plan

Wrote and tested rules with the new policy:

Screen Shot 2018-01-25 at 8.10.46 AM.png (1×2 px, 186 KB)

Screen Shot 2018-01-25 at 8.10.36 AM.png (1×2 px, 253 KB)

Also wrote and tested rules with the old policies:

Screen Shot 2018-01-25 at 8.19.44 AM.png (1×2 px, 184 KB)

Diff Detail

Repository
rP Phabricator
Branch
herald5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19181
Build 25905: Run Core Tests
Build 25904: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
herald/
adapter/
14 lines
controller/
2 lines
engine/
98 lines
storage/
12 lines

Diff 45400

View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleController.php

Loading...
View Options

src/applications/herald/engine/HeraldEngine.php

Loading...
View Options

src/applications/herald/storage/HeraldRule.php

Loading...
Phabricator · Built by Phacility