HomePhabricator

Implement an "only if the rule did not match last time" policy for Herald rules

Tags
None
Referenced Files
F5394971: Screen Shot 2018-01-25 at 8.10.46 AM.png
Jan 26 2018, 7:06 PM
F5394972: Screen Shot 2018-01-25 at 8.10.36 AM.png
Jan 26 2018, 7:06 PM
F5394973: Screen Shot 2018-01-25 at 8.19.44 AM.png
Jan 26 2018, 7:06 PM
Subscribers
None

Description

Implement an "only if the rule did not match last time" policy for Herald rules

Summary: Depends on D18927. Ref T13048. This implements a new policy which allows Herald rules to fire on some kinds of state changes.

Test Plan:
Wrote and tested rules with the new policy:

Screen Shot 2018-01-25 at 8.10.46 AM.png (1×2 px, 186 KB)

Screen Shot 2018-01-25 at 8.10.36 AM.png (1×2 px, 253 KB)

Also wrote and tested rules with the old policies:

Screen Shot 2018-01-25 at 8.19.44 AM.png (1×2 px, 184 KB)

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13048

Differential Revision: https://secure.phabricator.com/D18930