Page MenuHomePhabricator

Pass a real viewer to HeraldAdapter when doing test console runs
ClosedPublic

Authored by epriestley on Jan 25 2018, 7:31 PM.
Tags
None
Referenced Files
F15532132: D18933.id45404.diff
Wed, Apr 23, 2:32 PM
F15518733: D18933.id.diff
Sat, Apr 19, 4:23 PM
F15517018: D18933.diff
Fri, Apr 18, 11:33 PM
F15513774: D18933.diff
Thu, Apr 17, 9:46 PM
F15503330: D18933.diff
Mon, Apr 14, 9:06 AM
F15482840: D18933.id45426.diff
Wed, Apr 9, 8:25 AM
F15467435: D18933.id45404.diff
Thu, Apr 3, 2:52 PM
F15430670: D18933.diff
Mar 24 2025, 8:32 AM
Subscribers
None

Details

Summary

Depends on D18932. Ref T13048. See PHI276. In the cluster, we don't have device keys on web nodes. This is generally good, since they don't need them, and it means that we aren't putting more credentials than we need on those hosts.

However, it means that when we pull diff content to test "Commit" rules via the Herald test console, we use the omnipotent user and try to use device credentials, and this fails since we don't have any.

Instead, pass the real viewer in this case so we just sign the request as them, like we do for normal Diffusion requests.

Test Plan

Wrote and ran a commit content rule locally, no issues.

This isn't completely convincing since my local setup does have device credentials, but I'll double-check in production once this deploys.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 26 2018, 6:46 PM
This revision was automatically updated to reflect the committed changes.