Page MenuHomePhabricator

Mark the "Reviewer" field for Commits as deprecated
ClosedPublic

Authored by epriestley on Jan 25 2018, 6:28 PM.
Tags
None
Referenced Files
F19019576: D18932.diff
Nov 23 2025, 3:17 PM
F19015547: D18932.id.diff
Nov 23 2025, 12:33 AM
F18946360: D18932.diff
Nov 11 2025, 8:04 PM
F18839207: D18932.diff
Oct 27 2025, 3:00 PM
F18828364: D18932.id45402.diff
Oct 24 2025, 3:53 PM
F18814685: D18932.diff
Oct 20 2025, 11:45 PM
F18746003: D18932.id45402.diff
Oct 3 2025, 10:43 AM
F18745383: D18932.diff
Oct 3 2025, 6:29 AM
Subscribers
None

Details

Summary

Depends on D18931. Ref T13048. Ref T13041. This field means "the first accepting reviewer, where order is mostly arbitrary". Modern rules should almost certainly use "Accepting Reviewers" instead.

Getting rid of this completely is a pain, but we can at least reduce confusion by marking it as not-the-new-hotness. Add a "Deprecated" group, move it there, and mark it for exile.

Test Plan

Edited a commit rule, saw it in "Deprecated" group at the bottom of the list:

Screen Shot 2018-01-25 at 10.25.41 AM.png (772×403 px, 88 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable