Page MenuHomePhabricator

Update EditEngine pages to take a page header separate

Authored by chad on Sep 4 2017, 10:33 PM.
Referenced Files
Unknown Object (File)
Feb 28 2023, 2:01 AM
Unknown Object (File)
Feb 23 2023, 10:26 PM
Unknown Object (File)
Feb 18 2023, 4:45 PM
Unknown Object (File)
Feb 9 2023, 10:01 AM
Unknown Object (File)
Feb 5 2023, 8:04 AM
Unknown Object (File)
Jan 31 2023, 7:59 PM
Unknown Object (File)
Jan 12 2023, 1:27 PM
Unknown Object (File)
Dec 31 2022, 11:38 AM



This simplifies EditEngine pages in general by removing the dual header, and extending to allow setting of a custom PHUIHeaderView if needed (like settings).

Test Plan

Review all settings pages, review task, project pages. This should all be fine, but is a big change maybe some layouts I'm not considering. Tested these all mobile, destkop as well.

image.png (1×2 px, 228 KB)

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Sep 5 2017, 1:13 PM
This revision was automatically updated to reflect the committed changes.