Page MenuHomePhabricator

Update EditEngine pages to take a page header separate
ClosedPublic

Authored by chad on Sep 4 2017, 10:33 PM.
Tags
None
Referenced Files
F11516855: D18527.diff
Tue, Jan 31, 7:59 PM
Unknown Object (File)
Thu, Jan 12, 1:27 PM
Unknown Object (File)
Dec 31 2022, 11:38 AM
Unknown Object (File)
Dec 20 2022, 6:02 AM
Unknown Object (File)
Dec 7 2022, 2:27 PM
Unknown Object (File)
Dec 7 2022, 2:26 PM
Unknown Object (File)
Dec 7 2022, 2:26 PM
Unknown Object (File)
Dec 7 2022, 2:26 PM
Subscribers

Details

Summary

This simplifies EditEngine pages in general by removing the dual header, and extending to allow setting of a custom PHUIHeaderView if needed (like settings).

Test Plan

Review all settings pages, review task, project pages. This should all be fine, but is a big change maybe some layouts I'm not considering. Tested these all mobile, destkop as well.

image.png (1×2 px, 228 KB)

Diff Detail

Repository
rP Phabricator
Branch
edit-engine-white (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18276
Build 24587: Run Core Tests
Build 24586: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Sep 5 2017, 1:13 PM
This revision was automatically updated to reflect the committed changes.