Page MenuHomePhabricator

Update EditEngine pages to take a page header separate
ClosedPublic

Authored by chad on Sep 4 2017, 10:33 PM.
Tags
None
Referenced Files
F13888611: D18527.diff
Fri, Oct 4, 5:05 AM
Unknown Object (File)
Tue, Oct 1, 6:38 PM
Unknown Object (File)
Tue, Oct 1, 6:44 AM
Unknown Object (File)
Tue, Sep 24, 5:24 AM
Unknown Object (File)
Thu, Sep 12, 6:38 PM
Unknown Object (File)
Sep 1 2024, 7:58 AM
Unknown Object (File)
Aug 18 2024, 4:34 PM
Unknown Object (File)
Aug 16 2024, 1:09 PM
Subscribers

Details

Summary

This simplifies EditEngine pages in general by removing the dual header, and extending to allow setting of a custom PHUIHeaderView if needed (like settings).

Test Plan

Review all settings pages, review task, project pages. This should all be fine, but is a big change maybe some layouts I'm not considering. Tested these all mobile, destkop as well.

image.png (1×2 px, 228 KB)

Diff Detail

Repository
rP Phabricator
Branch
edit-engine-white
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18315
Build 24648: Run Core Tests
Build 24647: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Sep 5 2017, 1:13 PM
This revision was automatically updated to reflect the committed changes.