Differential D18527

Update EditEngine pages to take a page header separate
ClosedPublic
Actions

Authored by chad on Sep 4 2017, 10:33 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 13, 6:40 AM

	Unknown Object (File)
	Tue, Dec 10, 1:20 PM

	Unknown Object (File)
	Mon, Dec 9, 4:14 PM

	Unknown Object (File)
	Wed, Nov 27, 10:03 PM

	Unknown Object (File)
	Tue, Nov 26, 4:33 PM

	Unknown Object (File)
	Tue, Nov 26, 1:42 PM

	Unknown Object (File)
	Sun, Nov 24, 1:19 PM

	Unknown Object (File)
	Sun, Nov 24, 12:57 AM

Subscribers

Details

Reviewers

Commits

rPa903388d4f89: Update EditEngine pages to take a page header separate

Summary

This simplifies EditEngine pages in general by removing the dual header, and extending to allow setting of a custom PHUIHeaderView if needed (like settings).

Test Plan

Review all settings pages, review task, project pages. This should all be fine, but is a big change maybe some layouts I'm not considering. Tested these all mobile, destkop as well.

image.png (1×2 px, 228 KB)

Diff Detail

Repository

Branch

edit-engine-white (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18275
Build 24585: Run Core Tests
Build 24584: arc lint + arc unit

Event Timeline

chad created this revision.Sep 4 2017, 10:33 PM

Herald added a subscriber: Korvin. · View Herald TranscriptSep 4 2017, 10:33 PM

Harbormaster completed remote builds in B18275: Diff 44491.Sep 4 2017, 10:34 PM

chad edited the test plan for this revision. (Show Details)Sep 4 2017, 10:35 PM

chad added a parent revision: D18526: Update Settings for WHITE_CONFIG style boxes.

remove unused var

Harbormaster completed remote builds in B18276: Diff 44492.Sep 4 2017, 11:15 PM

Harbormaster completed remote builds in B18276: Diff 44492.

chad added a child revision: D18528: Update Dashboards for new Edit UI.Sep 4 2017, 11:40 PM

chad added a child revision: D18529: Update Create Diff page for new Edit UI.Sep 4 2017, 11:45 PM

chad added a child revision: D18530: Update Pholio Edit pages to new UI.Sep 4 2017, 11:52 PM

chad added a child revision: D18531: Update Phriction with new Edit UI.Sep 4 2017, 11:59 PM

chad added a child revision: D18532: Update Drydock to new Edit UI.Sep 5 2017, 1:29 AM

epriestley accepted this revision.Sep 5 2017, 1:13 PM

This revision is now accepted and ready to land.Sep 5 2017, 1:13 PM

rebase

Closed by commit rPa903388d4f89: Update EditEngine pages to take a page header separate (authored by Chad Little <chad@phacility.com>). · Explain WhySep 6 2017, 3:07 AM

This revision was automatically updated to reflect the committed changes.

Harbormaster completed remote builds in B18315: Diff 44532.Sep 6 2017, 3:07 AM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

6 lines

src/

applications/

settings/

editor/

PhabricatorSettingsEditEngine.php

25 lines

transactions/

editengine/

PhabricatorEditEngine.php

29 lines

view/

phui/

PHUITwoColumnView.php

4 lines

webroot/

rsrc/

css/

phui/

phui-two-column-view.css

4 lines

Diff 44491

resources/celerity/map.php

Loading...

src/applications/settings/editor/PhabricatorSettingsEditEngine.php

Loading...

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...

src/view/phui/PHUITwoColumnView.php

Loading...

webroot/rsrc/css/phui/phui-two-column-view.css

Loading...