Page MenuHomePhabricator

Update EditEngine pages to take a page header separate
ClosedPublic

Authored by chad on Sep 4 2017, 10:33 PM.
Tags
None
Referenced Files
F17652444: D18527.id44532.diff
Sat, Jul 12, 6:44 AM
F17635600: D18527.diff
Fri, Jul 11, 3:57 AM
Unknown Object (File)
Tue, Jun 17, 7:12 AM
Unknown Object (File)
Jun 12 2025, 11:36 AM
Unknown Object (File)
Jun 7 2025, 3:40 AM
Unknown Object (File)
Jun 6 2025, 9:14 PM
Unknown Object (File)
Jun 1 2025, 10:34 PM
Unknown Object (File)
May 30 2025, 4:05 AM
Subscribers

Details

Summary

This simplifies EditEngine pages in general by removing the dual header, and extending to allow setting of a custom PHUIHeaderView if needed (like settings).

Test Plan

Review all settings pages, review task, project pages. This should all be fine, but is a big change maybe some layouts I'm not considering. Tested these all mobile, destkop as well.

image.png (1×2 px, 228 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Sep 5 2017, 1:13 PM
This revision was automatically updated to reflect the committed changes.