Page MenuHomePhabricator

[WIP] Masking space when only one active space

Authored by tycho.tatitscheff on Sep 18 2015, 4:16 PM.



Fixes T9425.
Fixes T9436.
As discussed in T9425, once one tested Spaces, there is no way to end the test comppletly.
In fact, some disturbing Select element remains, torturing the mind of the administrator, who tested Spaces.
Moreover it is even more disturbing for the users who have been promised that Spaces will be removed completly.

Test Plan

This is WIP, really not for direct merged.
I will do extensive test try on developpement server, once I get some review.

Diff Detail

rP Phabricator
Lint Passed
Tests Skipped
Build Status
Buildable 8004
Build 9038: [Placeholder Plan] Wait for 30 Seconds
Build 9037: arc lint + arc unit

Event Timeline

tycho.tatitscheff retitled this revision from to [WIP] Masking space when only one active space.
tycho.tatitscheff updated this object.
tycho.tatitscheff edited the test plan for this revision. (Show Details)
tycho.tatitscheff added reviewers: chad, epriestley.

That is my jokker question.

I have no clue, how make javelin mask some item depending on an PhabricatorCursorPagedPolicyAwareQuery.
Shall i pass something in config ? And then display space or not dependingon config ?


This is what T9425/Q135 was about !
Masking Spaces Select if there is not 2 or more active Space.

  • Very WIP (pseudo code) test of masking Javelin Space 'Shift to space'
tycho.tatitscheff added inline comments.

My solution should work !
It is maybe ugly.

@epriestley, @chad : ready for a review if time !


should be select_items or select_rows or action_rows

@epriestley, what do you think conceptually of this ?? If you have time giving me some thought ?

@chad i'm not asking for a full review nor for merging it soon (TM) !
I was just wondering what revision I had open and thus I was asking if it could be an working way to fix T9425 and T9436.
I fully understand if you have no time to look at it.

I fully understand if you have no time to look at it.

I think there is still some miscommunication going on, or maybe the documentation we provide and point people to isn't clear. We'd prefer not to have tasks and diffs pinged for updates because:

  1. It's disruptive to the upstream productivity.
  2. If newer information existed, it would already be on the task or diff.

If you have an urgent need, please consider Paid Prioritization or Consulting. Otherwise, expect us to follow up naturally when we're ready.