Ref T5568. As discussed in IRC. This is very rough and not widely useable, but represents a solid first step.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T5568: Support `.arcunit`, similar to `.arclint`
- Commits
- rARC59698df856dd: Rough version of configuration driven unit test engine
Ran arc unit with a bunch of flags.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- master
- Lint
Lint Passed Severity Location Code Message Advice src/unit/engine/ArcanistConfigurationDrivenUnitTestEngine.php:79 XHP16 TODO Comment Advice src/unit/engine/ArcanistConfigurationDrivenUnitTestEngine.php:131 XHP16 TODO Comment Advice src/unit/engine/ArcanistConfigurationDrivenUnitTestEngine.php:139 XHP16 TODO Comment Advice src/unit/engine/ArcanistConfigurationDrivenUnitTestEngine.php:163 XHP16 TODO Comment - Unit
Test Failures - Build Status
Buildable 7271 Build 7581: [Placeholder Plan] Wait for 30 Seconds Build 7580: arc lint + arc unit
Event Timeline
| src/unit/engine/ArcanistConfigurationDrivenTestEngine.php | ||
|---|---|---|
| 7 ↗ | (On Diff #32820) | Maybe only true if at least one configured engine supports --everything. |
| 69–72 ↗ | (On Diff #32820) | Could we just do the type check first, and simplify this a bit? |
| 120 ↗ | (On Diff #32820) | I think we should move away from support for this (and "postponed" linters) -- these models never really made sense, and Harbormaster is on the horizon now. Fine to maintain support if it's "free", but feel free to just drop it if it's non-free, too. |
| 125 ↗ | (On Diff #32820) | At some point, maybe we should emit a warning here if an engine doesn't support --everything, to reduce surprise when --everything does not really mean --everything. |
| 128 ↗ | (On Diff #32820) | Consider type checking the results, similar to D13486, to place blame on bad engines more clearly. |
| 150 ↗ | (On Diff #32820) | (Is this essentially identical to something in the Lint engine?) |
Comment Actions
We're using this as part of our development workflow now and it's nice. It would be nice if it made use of our phpunit.xml configuration, but we can work around that for now. I hope this lands on master soon.
Thanks @joshuaspence!