Raise a more tailored error message when a third-party test engine returns bad results
ClosedPublic
Actions

Authored by epriestley on Jun 30 2015, 2:12 PM.

Details

Reviewers

joshuaspence
btrahan

Maniphest Tasks

T8714: Obscure error when a UnitEngine returns wrong result type

Commits

rARCd54cb072facd: Raise a more tailored error message when a third-party test engine returns…

Summary

Fixes T8714. When a test engine isn't returning the correct result type, shift suspicion onto it.

Test Plan

Faked error, got exception blaming test engine.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 32625.Jun 30 2015, 2:12 PM

epriestley retitled this revision from to Raise a more tailored error message when a third-party test engine returns bad results.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, joshuaspence.

epriestley added a task: T8714: Obscure error when a UnitEngine returns wrong result type.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 30 2015, 2:12 PM

btrahan accepted this revision.Jun 30 2015, 6:13 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jun 30 2015, 6:13 PM

Closed by commit rARCd54cb072facd: Raise a more tailored error message when a third-party test engine returns… (authored by epriestley, committed by epriestley). · Explain WhyJul 1 2015, 11:48 AM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D13579: Rough version of configuration driven unit test engine.Jul 7 2015, 3:34 PM

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistUnitWorkflow.php

41 lines

Diff 32669

View Options

src/workflow/ArcanistUnitWorkflow.php

Raise a more tailored error message when a third-party test engine returns bad resultsClosedPublicActions