Paths

Table of Contentst

Differential D10914

Configuration-driven Unit tests
AbandonedPublic
Actions

Authored by avivey on Dec 2 2014, 12:32 AM.

Tags

None

Referenced Files

	F18936439: D10914.diff
	Mon, Nov 10, 8:14 PM

	F18869543: D10914.id.diff
	Tue, Nov 4, 12:16 PM

	F18866673: D10914.id26216.diff
	Mon, Nov 3, 6:34 PM

	F18855714: D10914.diff
	Sat, Nov 1, 6:24 AM

	F18829714: D10914.id.diff
	Oct 25 2025, 12:16 AM

	F18815730: D10914.id26216.diff
	Oct 21 2025, 3:24 AM

	F18739514: D10914.id.diff
	Oct 1 2025, 9:45 PM

	F18726212: D10914.diff
	Sep 30 2025, 6:19 AM

Subscribers

Details

Reviewers

joshuaspence
epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5568: Support `.arcunit`, similar to `.arclint`

Summary

Ref T5568 - V0.

A new "MetaEngine" based on ConfigurationDrivenLintEngine, with "files" key that is a
map regex->replace, as in T5568#66793.

Updated PhutilTestEngine and NoseTestEngine, which are easiest for me to test; An "AnyBinTestEngine" (not
included here) would eventually grow to cover the "run this custom script" use-case.

Some names still need work...

Test Plan

arc unit in arcanist, and in a python repo using pynose; With --no-coverage, --detailed-coverage, --everything, path.

Diff Detail

Repository

Branch

unit

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	src/unit/engine/ConfigDrivenMetaEngine.php:3	TXT3	Line Too Long
Warning	src/unit/engine/ConfigDrivenMetaEngine.php:55	TXT3	Line Too Long
Warning	src/unit/engine/ConfigDrivenMetaEngine.php:138	TXT3	Line Too Long
Warning	src/unit/engine/NoseTestEngine.php:22	TXT3	Line Too Long
Advice	src/unit/engine/ArcanistUnitTestEngine.php:9	XHP16	TODO Comment
Advice	src/unit/engine/ConfigDrivenMetaEngine.php:15	XHP16	TODO Comment
Advice	src/unit/engine/ConfigDrivenMetaEngine.php:149	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 3157
Build 3163: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

avivey updated this revision to Diff 26216.Dec 2 2014, 12:32 AM

avivey retitled this revision from to Configuration-driven Unit tests.

avivey updated this object.

avivey edited the test plan for this revision. (Show Details)

avivey added reviewers: epriestley, joshuaspence.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 2 2014, 12:32 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Harbormaster completed remote builds in B3157: Diff 26216.Dec 2 2014, 12:33 AM

avivey updated this object.Dec 2 2014, 12:33 AM

avivey edited edge metadata.

avivey added a task: T5568: Support `.arcunit`, similar to `.arclint`.

jobertabma added a subscriber: jobertabma.Dec 2 2014, 4:07 PM

I'm keeping this revision 'alive' in case somebody wants to look at it, but I'd be a little surprised if it ~~sill~~ compiles.

If somebody wants to look at this, they should look at D13579 instead.

Revision Contents
Changeset List

Path

Size

2 lines

7 lines

src/

__phutil_library_map__.php

2 lines

unit/

engine/

ArcanistUnitTestEngine.php

17 lines

ConfigDrivenMetaEngine.php

269 lines

NoseTestEngine.php

35 lines

PhutilUnitTestEngine.php

9 lines

Diff 26216

.arcconfig

Loading...

.arcunit

Loading...

src/__phutil_library_map__.php

Loading...

src/unit/engine/ArcanistUnitTestEngine.php

Loading...

src/unit/engine/ConfigDrivenMetaEngine.php

Loading...

src/unit/engine/NoseTestEngine.php

Loading...

src/unit/engine/PhutilUnitTestEngine.php

Loading...