Page MenuHomePhabricator
Differential D10914

Configuration-driven Unit tests
AbandonedPublic
Actions

Authored by avivey on Dec 2 2014, 12:32 AM.
Tags
None
Referenced Files
F15344171: D10914.id26216.diff
Mon, Mar 10, 2:42 AM
F15344170: D10914.id.diff
Mon, Mar 10, 2:42 AM
Unknown Object (File)
Tue, Feb 25, 12:36 AM
Unknown Object (File)
Mon, Feb 24, 2:29 PM
Unknown Object (File)
Sat, Feb 22, 2:19 AM
Unknown Object (File)
Thu, Feb 20, 9:16 PM
Unknown Object (File)
Feb 14 2025, 7:18 PM
Unknown Object (File)
Feb 13 2025, 12:33 AM
View All Files
Subscribers
epriestley
jobertabma
Korvin

Details

Reviewers
joshuaspence
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5568: Support `.arcunit`, similar to `.arclint`
Summary

Ref T5568 - V0.

A new "MetaEngine" based on ConfigurationDrivenLintEngine, with "files" key that is a
map regex->replace, as in T5568#66793.

Updated PhutilTestEngine and NoseTestEngine, which are easiest for me to test; An "AnyBinTestEngine" (not
included here) would eventually grow to cover the "run this custom script" use-case.

Some names still need work...

Test Plan

arc unit in arcanist, and in a python repo using pynose; With --no-coverage, --detailed-coverage, --everything, path.

Diff Detail

Repository
rARC Arcanist
Branch
unit
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/unit/engine/ConfigDrivenMetaEngine.php:3TXT3Line Too Long
Warningsrc/unit/engine/ConfigDrivenMetaEngine.php:55TXT3Line Too Long
Warningsrc/unit/engine/ConfigDrivenMetaEngine.php:138TXT3Line Too Long
Warningsrc/unit/engine/NoseTestEngine.php:22TXT3Line Too Long
Advicesrc/unit/engine/ArcanistUnitTestEngine.php:9XHP16TODO Comment
Advicesrc/unit/engine/ConfigDrivenMetaEngine.php:15XHP16TODO Comment
Advicesrc/unit/engine/ConfigDrivenMetaEngine.php:149XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 3157
Build 3163: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

avivey updated this revision to Diff 26216.Dec 2 2014, 12:32 AM
avivey retitled this revision from to Configuration-driven Unit tests.
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
avivey added reviewers: epriestley, joshuaspence.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 2 2014, 12:32 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
Harbormaster completed remote builds in B3157: Diff 26216.Dec 2 2014, 12:33 AM
avivey updated this object.Dec 2 2014, 12:33 AM
avivey edited edge metadata.
avivey added a task: T5568: Support `.arcunit`, similar to `.arclint`.
jobertabma added a subscriber: jobertabma.Dec 2 2014, 4:07 PM
avivey planned changes to this revision.Jul 4 2015, 3:23 AM

I'm keeping this revision 'alive' in case somebody wants to look at it, but I'd be a little surprised if it sill compiles.

avivey abandoned this revision.Jul 10 2015, 4:17 AM

If somebody wants to look at this, they should look at D13579 instead.

Revision Contents
Changeset List

Diff 26216

View Options

.arcconfig

Loading...
View Options

.arcunit

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/unit/engine/ArcanistUnitTestEngine.php

Loading...
View Options

src/unit/engine/ConfigDrivenMetaEngine.php

Loading...
View Options

src/unit/engine/NoseTestEngine.php

Loading...
View Options

src/unit/engine/PhutilUnitTestEngine.php

Loading...
Phabricator · Built by Phacility