Fixes T9131. As of D13579, unit tests results were no longer rendered progressively. The issue here is that the rendering is being done in ArcanistConfigurationDrivenUnitTestEngine rather than in the child test engines, and only after $engine->run() had returned (i.e. after all tests within a test engine had completed).
- Group Reviewers
- Maniphest Tasks
- T9131: `arc unit` doesn't output progressive results
Ran arc unit, saw progressive results.
I think that this is not desirable behavior. In this particular case, I completely forgot that I had submitted the three diffs on top of each other, and so clicking "Land Revision" and seeing all three squashed into one was surprising. If I had used arc land locally then I could have verified the state before pushing.
The button will cease to work in this case in the future, rejecting the land because it would land unlanded, unreviewed commits. But will always mean "land this state", just like arc land does.