Page MenuHomePhabricator
Differential D10004

Remove deprecated "base" classes
ClosedPublic
Actions

Authored by joshuaspence on Jul 21 2014, 9:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 2:22 AM
Unknown Object (File)
Wed, May 1, 1:18 PM
Unknown Object (File)
Wed, May 1, 3:02 AM
Unknown Object (File)
Mon, Apr 29, 1:47 PM
Unknown Object (File)
Fri, Apr 26, 3:41 PM
Unknown Object (File)
Wed, Apr 24, 9:57 PM
Unknown Object (File)
Sun, Apr 21, 3:54 PM
Unknown Object (File)
Wed, Apr 17, 2:59 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5655: Standardize naming conventions
Commits
rARCf9cefb7e2d9d: Remove deprecated "base" classes
Summary

Ref T5655. After D9983, ArcanistBaseWorkflow and ArcanistBaseUnitTestEngine are deprecated.

Test Plan

Wait a sufficient amount of time before landing this.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 24046.Jul 21 2014, 9:53 PM
joshuaspence retitled this revision from to [LATER] Remove deprecated "base" classes..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 21 2014, 9:53 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1817: Diff 24046.Jul 21 2014, 9:55 PM
joshuaspence retitled this revision from [LATER] Remove deprecated "base" classes. to [LATER] Remove deprecated "base" classes.Sep 22 2014, 2:23 PM
joshuaspence edited edge metadata.
joshuaspence mentioned this in T6184: Incorrect date shown on hover.Sep 25 2014, 12:41 PM
joshuaspence retitled this revision from [LATER] Remove deprecated "base" classes to Remove deprecated "base" classes.Dec 30 2014, 11:46 PM
joshuaspence updated this object.Feb 8 2015, 11:23 AM
joshuaspence added a task: T5655: Standardize naming conventions.
epriestley accepted this revision.May 14 2015, 2:54 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 14 2015, 2:54 PM
joshuaspence updated this revision to Diff 30960.May 16 2015, 12:20 AM
joshuaspence edited edge metadata.

Rebase

Closed by commit rARCf9cefb7e2d9d: Remove deprecated "base" classes (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 16 2015, 12:21 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 30961

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/unit/engine/ArcanistBaseUnitTestEngine.php

Loading...
View Options

src/unit/engine/ArcanistUnitTestEngine.php

Loading...
View Options

src/workflow/ArcanistBaseWorkflow.php

Loading...
View Options

src/workflow/ArcanistWorkflow.php

Loading...
Phabricator · Built by Phacility