HomePhabricator

Don't explicitly name abstract base classes

Description

Don't explicitly name abstract base classes

Summary:
Ref T5655. It is superfluous to include "base" in the name of an abstract base class. Furthermore, it is not done consistently within the code base.

In order to retain compatibility with external code, I have kept the ArcanistBaseWorkflow class (which trivially extends from ArcanistWorkflow), but it is now deprecated and should output a warning message. Similarly for ArcanistBaseUnitTestEngine.

Test Plan: Created a workflow which extends from ArcanistBaseWorkflow. Executed the workflow and saw a deprecation warning.

Reviewers: Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: epriestley, Korvin, aurelijus

Maniphest Tasks: T5655

Differential Revision: https://secure.phabricator.com/D9983

Details

Provenance
joshuaspenceAuthored on
joshuaspencePushed on Jul 21 2014, 9:49 PM
Reviewer
Blessed Reviewers
Differential Revision
D9983: Don't explicitly name abstract base classes
Parents
rARCc6e6227ef9bf: Use have/need data in ArcanistPhutilLibraryLinter
Branches
Unknown
Tags
Unknown

Event Timeline