Page MenuHomePhabricator
Differential D10004

Remove deprecated "base" classes
ClosedPublic
Actions

Authored by joshuaspence on Jul 21 2014, 9:53 PM.
Tags
None
Referenced Files
F19051024: D10004.diff
Thu, Nov 27, 11:01 PM
F19039704: D10004.id.diff
Wed, Nov 26, 8:51 AM
F19035653: D10004.diff
Tue, Nov 25, 5:35 PM
F18861631: D10004.diff
Sun, Nov 2, 4:10 PM
F18818742: D10004.id.diff
Oct 22 2025, 2:06 AM
F18817872: D10004.id30960.diff
Oct 21 2025, 7:15 PM
F18814355: D10004.diff
Oct 20 2025, 11:03 PM
F18811184: D10004.id24046.diff
Oct 20 2025, 1:39 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5655: Standardize naming conventions
Commits
rARCf9cefb7e2d9d: Remove deprecated "base" classes
Summary

Ref T5655. After D9983, ArcanistBaseWorkflow and ArcanistBaseUnitTestEngine are deprecated.

Test Plan

Wait a sufficient amount of time before landing this.

Diff Detail

Repository
rARC Arcanist
Branch
rmbase
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1817
Build 1818: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 24046.Jul 21 2014, 9:53 PM
joshuaspence retitled this revision from to [LATER] Remove deprecated "base" classes..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 21 2014, 9:53 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1817: Diff 24046.Jul 21 2014, 9:55 PM
joshuaspence retitled this revision from [LATER] Remove deprecated "base" classes. to [LATER] Remove deprecated "base" classes.Sep 22 2014, 2:23 PM
joshuaspence edited edge metadata.
joshuaspence mentioned this in T6184: Incorrect date shown on hover.Sep 25 2014, 12:41 PM
joshuaspence retitled this revision from [LATER] Remove deprecated "base" classes to Remove deprecated "base" classes.Dec 30 2014, 11:46 PM
joshuaspence updated this object.Feb 8 2015, 11:23 AM
joshuaspence added a task: T5655: Standardize naming conventions.
epriestley accepted this revision.May 14 2015, 2:54 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 14 2015, 2:54 PM
joshuaspence updated this revision to Diff 30960.May 16 2015, 12:20 AM
joshuaspence edited edge metadata.

Rebase

Closed by commit rARCf9cefb7e2d9d: Remove deprecated "base" classes (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 16 2015, 12:21 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 24046

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/unit/engine/ArcanistBaseUnitTestEngine.php

Loading...
View Options

src/unit/engine/ArcanistUnitTestEngine.php

Loading...
View Options

src/workflow/ArcanistBaseWorkflow.php

Loading...
View Options

src/workflow/ArcanistWorkflow.php

Loading...
Phabricator · Built by Phacility