Page MenuHomePhabricator
Feed Advanced Search

Oct 30 2015

marceldegraaf closed T9671: Harbormaster builds and Drydock leases are stuck as Resolved.

Thanks for your reply, the detailed description really helps. The build system works now, and even though the "Lease Working Copy" step doesn't really make sense for us, I'm really glad everything works :-).

Oct 30 2015, 2:29 PM · Harbormaster, Drydock
marceldegraaf added a comment to T9671: Harbormaster builds and Drydock leases are stuck.

Thanks for reopening @tycho.tatitscheff. Before I document anything officially I'd like to wait for @epriestley's answer on T9671#142468, to make sure I'm not Doing It Wrong™ :-).

Oct 30 2015, 9:50 AM · Harbormaster, Drydock
marceldegraaf added a comment to T9671: Harbormaster builds and Drydock leases are stuck.

Thanks, I set "Also Clone" to a random repository and that solves the exception I pasted. I got my builds working again. For future generations: this is how I configured Almanac/Drydock/Harbormaster now:

Oct 30 2015, 7:49 AM · Harbormaster, Drydock

Oct 29 2015

marceldegraaf added a comment to T9671: Harbormaster builds and Drydock leases are stuck.

Alright, I've managed to upgrade Phabricator and fix the storage schemata issues. I've also reconfigured Almanac, Drydock, and Harbormaster to reflect the latest changes regarding blueprint authorizations. My Harbormaster build step is authorized on the Drydock blueprint, so that looks good.

Oct 29 2015, 10:14 PM · Harbormaster, Drydock
marceldegraaf added a comment to T9671: Harbormaster builds and Drydock leases are stuck.

Upgrading Phabricator to the latest HEAD, and running ./bin/storage upgrade results in this error:

Oct 29 2015, 9:15 PM · Harbormaster, Drydock
marceldegraaf added a comment to T9671: Harbormaster builds and Drydock leases are stuck.

Thanks, I'll read those. However, I'd still like to know why Drydock leases suddenly stopped working, and why I can't cancel them to free up the daemons, and there's no way to cancel or remove the build tasks from the daemons, too. They just keep retrying forever.

Oct 29 2015, 9:03 PM · Harbormaster, Drydock
marceldegraaf added a comment to T9671: Harbormaster builds and Drydock leases are stuck.

I have, a week or so ago. However, around October 12 "Blueprint Authorizations" were added to Drydock and those changes broke our entire build setup. There was no documentation on how to work with these Authorizations at the time (or I couldn't find it), so I rolled back to the last commit before those changes.

Oct 29 2015, 8:56 PM · Harbormaster, Drydock
marceldegraaf created T9671: Harbormaster builds and Drydock leases are stuck.
Oct 29 2015, 8:49 PM · Harbormaster, Drydock

Jul 6 2015

marceldegraaf added a comment to T8549: Feedback on 2015 Redesign.

While I agree that making the browser window narrower is a good work around for things like Phriction and Maniphest, it does get annoying when using Diffusion/Differential/Audit, to review code diffs. In those cases, you kind of need the horizontal space to be able to read the code easily. That means I would have to constantly resize my browser window when switching apps/context in Phabricator.

Jul 6 2015, 9:52 AM · Design

Jun 24 2015

marceldegraaf created T8656: Parse ANSI-style color strings in build output.
Jun 24 2015, 2:10 PM · Haskell.org, Restricted Project, Harbormaster

Jun 23 2015

marceldegraaf added a comment to T5726: Add more information to story POSTs during the feed.http-hooks hook.

@epriestley: this task being fixed might be an easier solution than writing our own Doorkeeper integration (as discussed on Conpherence today). I already have an application that receives feed data via POST; can I help test this change so we can get it merged?

Jun 23 2015, 7:22 PM · Feed
marceldegraaf added a comment to T8549: Feedback on 2015 Redesign.

Additionally, the font family of the preview seems to differ from the rendered result.

Jun 23 2015, 4:51 PM · Design
marceldegraaf added a comment to T8549: Feedback on 2015 Redesign.

@chad: I'm not sure if this has been mentioned before but it seems title tags (<h1>, <h2>, ...) render differently in the preview. Compare these screenshots from Phriction:

Jun 23 2015, 4:50 PM · Design

Jun 20 2015

marceldegraaf added a comment to T8549: Feedback on 2015 Redesign.

That's an awesome feature, @epriestley. I'm don't even need it myself, but I really love how Phabricator tries to be a tool for anyone to use, without getting in their way. We're about to move our entire company off of Github and onto Phabricator and it's things like this that reassure me we've made the right choice :-).

Jun 20 2015, 4:21 PM · Design

Jun 19 2015

marceldegraaf added a comment to T8549: Feedback on 2015 Redesign.

Would it be possible to support both fixed and fluid layouts? Or is that
going to be a pain to support for all the different apps?

Jun 19 2015, 8:50 PM · Design
marceldegraaf added a comment to T8549: Feedback on 2015 Redesign.
In T8549#121390, @chad wrote:

I had hoped to explore that this pass, but don't know if we'll fit that in. (I prefer centered, fixed-width content myself).

Jun 19 2015, 10:04 AM · Design

Jun 15 2015

marceldegraaf added a member for Space Test Users: marceldegraaf.
Jun 15 2015, 1:12 PM

May 29 2015

marceldegraaf closed T8353: Unhandled Exception when viewing a Diffusion commit as Resolved.

Yes, that solves it. Thanks!

May 29 2015, 2:23 PM · Diffusion
marceldegraaf created T8353: Unhandled Exception when viewing a Diffusion commit.
May 29 2015, 12:27 PM · Diffusion

May 21 2015

marceldegraaf accepted rP898ce6bace59: Search Symbols by Repository, not Project.

Issue T8283 was fixed in rPa50de8958efbb678173043f6b74bb5f3ea5d21e0

May 21 2015, 5:06 PM
marceldegraaf added a comment to T8283: Error thrown when opening a file in Diffusion's file browser.

Thanks @epriestley, just deployed this and can confirm that it's fixed.

May 21 2015, 5:05 PM · Diffusion
marceldegraaf added a comment to T8283: Error thrown when opening a file in Diffusion's file browser.

Addition: the error disappears when we disable syntax highlighting in the file browser.

May 21 2015, 10:20 AM · Diffusion
marceldegraaf raised a concern with rP898ce6bace59: Search Symbols by Repository, not Project.
May 21 2015, 10:19 AM
marceldegraaf added a comment to T8282: What is the purpose of creating an admin account?.

Not a maintainer, but maybe I can help; I had the same issue.

May 21 2015, 10:11 AM · Setup
marceldegraaf created T8283: Error thrown when opening a file in Diffusion's file browser.
May 21 2015, 10:03 AM · Diffusion

May 1 2015

marceldegraaf awarded T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects a Like token.
May 1 2015, 7:41 AM · Spaces, Wikimedia, Policy
marceldegraaf awarded T929: Allow two arbitrary revisions to be compared in Diffusion a Like token.
May 1 2015, 6:55 AM · Diffusion (v3), Restricted Project

Apr 24 2015

marceldegraaf added a comment to T7904: InvalidArgumentException in ManiphestTaskSearchEngine.php.

Sorry, those commit hashes are not correct. Issue seems to have been introduced in rPf64ca87bfea01a355f3fbf4fa03c460995b5da99

Apr 24 2015, 2:41 PM · Dashboards
marceldegraaf added a comment to T7904: InvalidArgumentException in ManiphestTaskSearchEngine.php.

Issue doesn't seem to be present in rP3a2c2ae3c3ae3d88427ec96787840119508c2e73, and appears in rPb49645d25b60329cfdd181d7b1dd1dbce30d349f (and in HEAD)

Apr 24 2015, 2:37 PM · Dashboards
marceldegraaf added a comment to T7904: InvalidArgumentException in ManiphestTaskSearchEngine.php.

This breaks the built-in "Authored" and "All Tasks" queries.

Apr 24 2015, 2:32 PM · Dashboards
marceldegraaf awarded T3725: Using keyword @ to address users does not autocomplete names a Like token.
Apr 24 2015, 9:04 AM · FreeBSD, User Delight, Remarkup

Apr 23 2015

marceldegraaf added a comment to D10063: (Partial) Provide more useful information on feed.http-hooks.

Bump; I'd like to see this added as well. Additionally, is there a way to get the actual comment text from "new comment" feed items? As far as I can see that is not possible now, and is not added in this revision.

Apr 23 2015, 9:21 AM