Fix XHPAST parsing of variadic calls
ClosedPublic
Actions

Authored by epriestley on Apr 7 2020, 9:12 PM.

Details

Reviewers: None
Maniphest Tasks: T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5
Commits: rARCe03431def8c0: Fix XHPAST parsing of variadic calls

Summary

Depends on D21066. Ref T13492. The switch of unit test data to stable/readable output exposed this bug in parsing of variadic calls: some nodes are not given types properly.

Fix the parser and update the test.

Test Plan

Ran the test, which now works.

Diff Detail

Repository

rARC Arcanist

Branch

xhpast5

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24005
Build 33040: Run Core Tests
Build 33039: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 7 2020, 9:12 PM

Harbormaster completed remote builds in B24005: Diff 50186.Apr 7 2020, 9:13 PM

epriestley requested review of this revision.Apr 7 2020, 9:13 PM

epriestley added a child revision: D21068: Fix improper XHPAST parsing of namespace grammar like "use x as private;".Apr 7 2020, 9:24 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 7 2020, 9:33 PM

Closed by commit rARCe03431def8c0: Fix XHPAST parsing of variadic calls (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCe03431def8c0: Fix XHPAST parsing of variadic calls.

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

__tests__/

data/

variadic.php.test

38 lines

bin/

PhutilXHPASTBinary.php

2 lines

support/

xhpast/

parser.y

7 lines

parser.yacc.cpp

Diff 50186

View Options

src/parser/xhpast/tests/data/variadic.php.test

View Options

src/parser/xhpast/bin/PhutilXHPASTBinary.php

View Options

support/xhpast/parser.y

View Options

support/xhpast/parser.yacc.cpp

Fix XHPAST parsing of variadic callsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50186

src/parser/xhpast/__tests__/data/variadic.php.test

src/parser/xhpast/bin/PhutilXHPASTBinary.php

support/xhpast/parser.y

support/xhpast/parser.yacc.cpp

Fix XHPAST parsing of variadic calls
ClosedPublic
Actions

Revision Contents
Changeset List

src/parser/xhpast/tests/data/variadic.php.test