Page MenuHomePhabricator

Fix XHPAST parsing of variadic calls
ClosedPublic

Authored by epriestley on Apr 7 2020, 9:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 18 2024, 6:06 AM
Unknown Object (File)
Feb 5 2024, 6:37 AM
Unknown Object (File)
Jan 28 2024, 2:00 PM
Unknown Object (File)
Dec 27 2023, 1:20 PM
Unknown Object (File)
Dec 27 2023, 1:20 PM
Unknown Object (File)
Dec 27 2023, 1:20 PM
Unknown Object (File)
Dec 24 2023, 11:27 PM
Unknown Object (File)
Dec 23 2023, 12:35 AM
Subscribers
None

Details

Summary

Depends on D21066. Ref T13492. The switch of unit test data to stable/readable output exposed this bug in parsing of variadic calls: some nodes are not given types properly.

Fix the parser and update the test.

Test Plan

Ran the test, which now works.

Diff Detail

Repository
rARC Arcanist
Branch
xhpast5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24005
Build 33040: Run Core Tests
Build 33039: arc lint + arc unit