Differential D21066

Update XHPAST "expect" test blocks to the new stable, human-readable format
ClosedPublic
Actions

Authored by epriestley on Apr 7 2020, 9:11 PM.

Details

Reviewers: None
Maniphest Tasks: T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5
Commits: rARCa689dee22826: Update XHPAST "expect" test blocks to the new stable, human-readable format

Summary

Depends on D21065. Ref T13492. Swap existing "expect" blocks from unstable, unreadable JSON to readable, stable trees.

(There are two "INVALID TYPE" outputs which this update effectively detects and which future changes correct.)

Test Plan

Ran "arc unit --everything", got a clean build.

Diff Detail

Repository

rARC Arcanist

Branch

xhpast4

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 24004
Build 33038: Run Core Tests
Build 33037: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 7 2020, 9:11 PM

Harbormaster completed remote builds in B24004: Diff 50185.Apr 7 2020, 9:11 PM

epriestley requested review of this revision.Apr 7 2020, 9:11 PM

epriestley added a child revision: D21067: Fix XHPAST parsing of variadic calls.Apr 7 2020, 9:12 PM

epriestley mentioned this in D17820: Replace all the PHPAST JSON test data with readable test data.Apr 7 2020, 9:28 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 7 2020, 9:32 PM

Closed by commit rARCa689dee22826: Update XHPAST "expect" test blocks to the new stable, human-readable format (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCa689dee22826: Update XHPAST "expect" test blocks to the new stable, human-readable format.

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

__tests__/

data/

anonymous_class.php.test

701 lines

base-pass.php.test

36 lines

call-time-pass-by-ref.php.test

115 lines

namespace.php.test

461 lines

operator-coalesce.php.test

145 lines

operator-spaceship.php.test

105 lines

optional-parameter.php.test

328 lines

php-access-on-instanciation.test

772 lines

php-array-dereference-2.test

212 lines

php-array-dereference-3.test

244 lines

php-array-dereference-4.test

176 lines

php-array-dereference.test

773 lines

php-binary-literal.php.test

60 lines

php-callable-typehint.php.test

169 lines

php-comments.php.test

71 lines

php-empty-heredoc.php.test

105 lines

php-finally.php.test

205 lines

php-literal-index.php.test

190 lines

php-literals.php.test

422 lines

php-only-finally.test

119 lines

php-short-array.php.test

78 lines

13417 lines

247 lines

1097 lines

523 lines

2561 lines

446 lines

844 lines

Diff 50185

View Options

src/parser/xhpast/tests/data/anonymous_class.php.test

View Options

src/parser/xhpast/tests/data/base-pass.php.test

View Options

src/parser/xhpast/tests/data/call-time-pass-by-ref.php.test

View Options

src/parser/xhpast/tests/data/namespace.php.test

View Options

src/parser/xhpast/tests/data/operator-coalesce.php.test

View Options

src/parser/xhpast/tests/data/operator-spaceship.php.test

View Options

src/parser/xhpast/tests/data/optional-parameter.php.test

View Options

src/parser/xhpast/tests/data/php-access-on-instanciation.test

View Options

src/parser/xhpast/tests/data/php-array-dereference-2.test

View Options

src/parser/xhpast/tests/data/php-array-dereference-3.test

View Options

src/parser/xhpast/tests/data/php-array-dereference-4.test

View Options

src/parser/xhpast/tests/data/php-array-dereference.test

View Options

src/parser/xhpast/tests/data/php-binary-literal.php.test

View Options

src/parser/xhpast/tests/data/php-callable-typehint.php.test

View Options

src/parser/xhpast/tests/data/php-comments.php.test

View Options

src/parser/xhpast/tests/data/php-empty-heredoc.php.test

View Options

src/parser/xhpast/tests/data/php-finally.php.test

View Options

src/parser/xhpast/tests/data/php-literal-index.php.test

View Options

src/parser/xhpast/tests/data/php-literals.php.test

View Options

src/parser/xhpast/tests/data/php-only-finally.test

View Options

src/parser/xhpast/tests/data/php-short-array.php.test

View Options

src/parser/xhpast/tests/data/php-syntax.php.test

View Options

src/parser/xhpast/tests/data/php-tags.php.test

View Options

src/parser/xhpast/tests/data/php-traits.php.test

View Options

src/parser/xhpast/tests/data/php-yield.php.test

View Options

src/parser/xhpast/tests/data/return-type.php.test

View Options

src/parser/xhpast/tests/data/use.php.test

View Options

src/parser/xhpast/tests/data/variadic.php.test

Update XHPAST "expect" test blocks to the new stable, human-readable formatClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50185

src/parser/xhpast/__tests__/data/anonymous_class.php.test

src/parser/xhpast/__tests__/data/base-pass.php.test

src/parser/xhpast/__tests__/data/call-time-pass-by-ref.php.test

src/parser/xhpast/__tests__/data/namespace.php.test

src/parser/xhpast/__tests__/data/operator-coalesce.php.test

src/parser/xhpast/__tests__/data/operator-spaceship.php.test

src/parser/xhpast/__tests__/data/optional-parameter.php.test

src/parser/xhpast/__tests__/data/php-access-on-instanciation.test

src/parser/xhpast/__tests__/data/php-array-dereference-2.test

src/parser/xhpast/__tests__/data/php-array-dereference-3.test

src/parser/xhpast/__tests__/data/php-array-dereference-4.test

src/parser/xhpast/__tests__/data/php-array-dereference.test

src/parser/xhpast/__tests__/data/php-binary-literal.php.test

src/parser/xhpast/__tests__/data/php-callable-typehint.php.test

src/parser/xhpast/__tests__/data/php-comments.php.test

src/parser/xhpast/__tests__/data/php-empty-heredoc.php.test

src/parser/xhpast/__tests__/data/php-finally.php.test

src/parser/xhpast/__tests__/data/php-literal-index.php.test

src/parser/xhpast/__tests__/data/php-literals.php.test

src/parser/xhpast/__tests__/data/php-only-finally.test

src/parser/xhpast/__tests__/data/php-short-array.php.test

src/parser/xhpast/__tests__/data/php-syntax.php.test

src/parser/xhpast/__tests__/data/php-tags.php.test

src/parser/xhpast/__tests__/data/php-traits.php.test

src/parser/xhpast/__tests__/data/php-yield.php.test

src/parser/xhpast/__tests__/data/return-type.php.test

src/parser/xhpast/__tests__/data/use.php.test

src/parser/xhpast/__tests__/data/variadic.php.test

Update XHPAST "expect" test blocks to the new stable, human-readable format
ClosedPublic
Actions

Revision Contents
Changeset List

src/parser/xhpast/tests/data/anonymous_class.php.test

src/parser/xhpast/tests/data/base-pass.php.test

src/parser/xhpast/tests/data/call-time-pass-by-ref.php.test

src/parser/xhpast/tests/data/namespace.php.test

src/parser/xhpast/tests/data/operator-coalesce.php.test

src/parser/xhpast/tests/data/operator-spaceship.php.test

src/parser/xhpast/tests/data/optional-parameter.php.test

src/parser/xhpast/tests/data/php-access-on-instanciation.test

src/parser/xhpast/tests/data/php-array-dereference-2.test

src/parser/xhpast/tests/data/php-array-dereference-3.test

src/parser/xhpast/tests/data/php-array-dereference-4.test

src/parser/xhpast/tests/data/php-array-dereference.test

src/parser/xhpast/tests/data/php-binary-literal.php.test

src/parser/xhpast/tests/data/php-callable-typehint.php.test

src/parser/xhpast/tests/data/php-comments.php.test

src/parser/xhpast/tests/data/php-empty-heredoc.php.test

src/parser/xhpast/tests/data/php-finally.php.test

src/parser/xhpast/tests/data/php-literal-index.php.test

src/parser/xhpast/tests/data/php-literals.php.test

src/parser/xhpast/tests/data/php-only-finally.test

src/parser/xhpast/tests/data/php-short-array.php.test

src/parser/xhpast/tests/data/php-syntax.php.test

src/parser/xhpast/tests/data/php-tags.php.test

src/parser/xhpast/tests/data/php-traits.php.test

src/parser/xhpast/tests/data/php-yield.php.test

src/parser/xhpast/tests/data/return-type.php.test

src/parser/xhpast/tests/data/use.php.test

src/parser/xhpast/tests/data/variadic.php.test