Paths

Table of Contentst

Integrate "ServiceProfiler" into the base "Future"
ClosedPublic
Actions

Authored by epriestley on Feb 27 2020, 2:53 PM.

Details

Reviewers: None
Maniphest Tasks: T11968: Decide the fate of FutureGraph
T13177: ServiceProfiler integration should be a configurable part of Future, not hard-coded into subclasses (HTTPSFuture, ExecFuture)
Commits: rARCb1a712add815: Integrate "ServiceProfiler" into the base "Future"

Summary

Depends on D21036. Ref T11968. Ref T13177. Currently, each Future integrates separately with ServiceProfiler, but much of the code is similar.

Move integration to the base class and lift up most of the implementation details.

Test Plan

Ran arc diff --trace, saw sensible output.

Diff Detail

Repository

rARC Arcanist

Branch

fx7

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/future/http/HTTPSFuture.php:214	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 23931
Build 32936: Run Core Tests
Build 32935: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 27 2020, 2:53 PM

Harbormaster completed remote builds in B23931: Diff 50110.Feb 27 2020, 2:53 PM

epriestley requested review of this revision.Feb 27 2020, 2:53 PM

epriestley mentioned this in T13177: ServiceProfiler integration should be a configurable part of Future, not hard-coded into subclasses (HTTPSFuture, ExecFuture).Feb 27 2020, 3:06 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 30 2020, 2:42 PM

Closed by commit rARCb1a712add815: Integrate "ServiceProfiler" into the base "Future" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCb1a712add815: Integrate "ServiceProfiler" into the base "Future".

Revision Contents
Changeset List

Path

Size

src/

future/

Future.php

43 lines

FutureProxy.php

8 lines

exec/

ExecFuture.php

55 lines

PhutilExecPassthru.php

36 lines

http/

HTTPFuture.php

17 lines

HTTPSFuture.php

20 lines

Diff 50110

View Options

src/future/Future.php

View Options

src/future/FutureProxy.php

View Options

src/future/exec/ExecFuture.php

View Options

src/future/exec/PhutilExecPassthru.php

View Options

src/future/http/HTTPFuture.php

View Options

src/future/http/HTTPSFuture.php

Integrate "ServiceProfiler" into the base "Future"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50110

src/future/Future.php

src/future/FutureProxy.php

src/future/exec/ExecFuture.php

src/future/exec/PhutilExecPassthru.php

src/future/http/HTTPFuture.php

src/future/http/HTTPSFuture.php

Integrate "ServiceProfiler" into the base "Future"
ClosedPublic
Actions

Revision Contents
Changeset List