Page MenuHomePhabricator
Differential D21038

Integrate "ServiceProfiler" into the base "Future"
ClosedPublic
Actions

Authored by epriestley on Feb 27 2020, 2:53 PM.
Tags
None
Referenced Files
F19152523: D21038.diff
Thu, Dec 11, 3:18 AM
F19083192: D21038.id50143.diff
Tue, Dec 2, 12:32 PM
F19046536: D21038.id.diff
Thu, Nov 27, 10:50 AM
F19000181: D21038.id50143.diff
Thu, Nov 20, 11:10 PM
F18999526: D21038.id50143.diff
Thu, Nov 20, 9:16 PM
F18999469: D21038.id50110.diff
Thu, Nov 20, 9:06 PM
F18999242: D21038.diff
Thu, Nov 20, 8:37 PM
F18985367: D21038.id50110.diff
Mon, Nov 17, 1:00 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T11968: Decide the fate of FutureGraph
T13177: ServiceProfiler integration should be a configurable part of Future, not hard-coded into subclasses (HTTPSFuture, ExecFuture)
Commits
rARCb1a712add815: Integrate "ServiceProfiler" into the base "Future"
Summary

Depends on D21036. Ref T11968. Ref T13177. Currently, each Future integrates separately with ServiceProfiler, but much of the code is similar.

Move integration to the base class and lift up most of the implementation details.

Test Plan

Ran arc diff --trace, saw sensible output.

Diff Detail

Repository
rARC Arcanist
Branch
fx7
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/future/http/HTTPSFuture.php:214XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 23931
Build 32936: Run Core Tests
Build 32935: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
future/
43 lines
8 lines
exec/
55 lines
36 lines
http/
17 lines
20 lines

Diff 50110

View Options

src/future/Future.php

Loading...
View Options

src/future/FutureProxy.php

Loading...
View Options

src/future/exec/ExecFuture.php

Loading...
View Options

src/future/exec/PhutilExecPassthru.php

Loading...
View Options

src/future/http/HTTPFuture.php

Loading...
View Options

src/future/http/HTTPSFuture.php

Loading...
Phabricator · Built by Phacility