Page MenuHomePhabricator

Integrate "ServiceProfiler" into the base "Future"
ClosedPublic

Authored by epriestley on Feb 27 2020, 2:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 8 2024, 6:15 PM
Unknown Object (File)
Feb 3 2024, 11:49 PM
Unknown Object (File)
Dec 20 2023, 2:11 PM
Unknown Object (File)
Dec 16 2023, 6:32 AM
Unknown Object (File)
Nov 29 2023, 11:38 PM
Unknown Object (File)
Nov 25 2023, 11:10 PM
Unknown Object (File)
Nov 15 2023, 1:43 AM
Unknown Object (File)
Nov 8 2023, 10:54 AM
Subscribers
None

Details

Summary

Depends on D21036. Ref T11968. Ref T13177. Currently, each Future integrates separately with ServiceProfiler, but much of the code is similar.

Move integration to the base class and lift up most of the implementation details.

Test Plan

Ran arc diff --trace, saw sensible output.

Diff Detail

Repository
rARC Arcanist
Branch
fx7
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/future/http/HTTPSFuture.php:214XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 23931
Build 32936: Run Core Tests
Build 32935: arc lint + arc unit