Make "FutureIterator" queue management more formal
ClosedPublic
Actions

Authored by epriestley on Feb 27 2020, 2:13 PM.

Details

Reviewers: None
Maniphest Tasks: T11968: Decide the fate of FutureGraph
Commits: rARCcb80f6971537: Make "FutureIterator" queue management more formal

Summary

Depends on D21035. Ref T11968. This allows a "FutureIterator" to hold futures which are blocked because of unresolved dependencies, and makes the resolution process more structured.

Test Plan

Ran unit tests, created this revision.

Diff Detail

Repository

rARC Arcanist

Branch

fx6

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23927
Build 32929: Run Core Tests
Build 32928: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	15 ms	ExecFutureTestCase::testResolveTimeoutTestShouldRunLessThan1Sec EXCEPTION (Exception): Future has already started; futures can not start more than once. #0 /core/data/drydock/workingcopy-83/repo/arcanist/src/future/FutureIterator.php(390): Future->startFuture() #1 /core/data/drydock/workingcopy-83/repo/arcanist/src/future/FutureIterator.php(366): FutureIterator->moveFutureToWork('Future/638')
	0 ms	AbstractDirectedGraphTestCase::testCyclicGraph 1 assertion(s) passed.
	1 ms	AbstractDirectedGraphTestCase::testEdgeLoadFailure 1 assertion(s) passed.
	0 ms	AbstractDirectedGraphTestCase::testNonTreeGraph 1 assertion(s) passed.
	0 ms	AbstractDirectedGraphTestCase::testNoncyclicGraph 1 assertion(s) passed.
		View Full Test Results (1 Failed · 488 Passed · 63 Skipped)