Make "FutureIterator" queue management more formal
ClosedPublic
Actions

Authored by epriestley on Feb 27 2020, 2:13 PM.

Details

Reviewers: None
Maniphest Tasks: T11968: Decide the fate of FutureGraph
Commits: rARCcb80f6971537: Make "FutureIterator" queue management more formal

Summary

Depends on D21035. Ref T11968. This allows a "FutureIterator" to hold futures which are blocked because of unresolved dependencies, and makes the resolution process more structured.

Test Plan

Ran unit tests, created this revision.

Diff Detail

Repository

rARC Arcanist

Branch

fx6

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23930
Build 32934: Run Core Tests
Build 32933: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 27 2020, 2:13 PM

Harbormaster completed remote builds in B23927: Diff 50106.Feb 27 2020, 2:13 PM

epriestley requested review of this revision.Feb 27 2020, 2:13 PM

Fix a unit test issue where a future was explicitly started before being added to an Iterator.

Harbormaster completed remote builds in B23930: Diff 50109.Feb 27 2020, 2:50 PM

epriestley added a child revision: D21038: Integrate "ServiceProfiler" into the base "Future".Feb 27 2020, 2:53 PM

epriestley mentioned this in T11968: Decide the fate of FutureGraph.Feb 27 2020, 3:30 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 30 2020, 2:42 PM

Closed by commit rARCcb80f6971537: Make "FutureIterator" queue management more formal (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCcb80f6971537: Make "FutureIterator" queue management more formal.

Revision Contents
Changeset List

Path

Size

src/

future/

Future.php

62 lines

FutureIterator.php

308 lines

exec/

__tests__/

ExecFutureTestCase.php

4 lines

lint/

linter/

ArcanistFutureLinter.php

3 lines

Diff 50109

View Options

src/future/Future.php

View Options

src/future/FutureIterator.php

View Options

src/future/exec/tests/ExecFutureTestCase.php

View Options

src/lint/linter/ArcanistFutureLinter.php

Make "FutureIterator" queue management more formalClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50109

src/future/Future.php

src/future/FutureIterator.php

src/future/exec/__tests__/ExecFutureTestCase.php

src/lint/linter/ArcanistFutureLinter.php

Make "FutureIterator" queue management more formal
ClosedPublic
Actions

Revision Contents
Changeset List

src/future/exec/tests/ExecFutureTestCase.php