Differential D20679

Tailor "Restart All Builds" for the complex realities of modern build restart rules
ClosedPublic
Actions

Authored by epriestley on Jul 24 2019, 3:14 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13348: "Restart All Builds" is misleading in the presence of non-restartable builds

Commits

rPf6621a5fdcff: Tailor "Restart All Builds" for the complex realities of modern build restart…

Summary

Fixes T13348. Currently, the Harbormaster UI shows "Restart All Builds", but it really means "Restart Restartable Builds", which is often fewer than "All" builds (because of autobuilds, permissions, and/or configuration).

Remove the misleading term "All" and make the workflow preview exactly which builds will and will not be affected, and why.

Test Plan

Screen Shot 2019-07-24 at 8.11.41 AM.png (785×1 px, 162 KB)

Screen Shot 2019-07-24 at 8.11.10 AM.png (762×1 px, 173 KB)

Screen Shot 2019-07-24 at 8.11.02 AM.png (762×1 px, 172 KB)

Diff Detail

Repository

rP Phabricator

Branch

restart1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 23188
Build 31849: Run Core Tests
Build 31848: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 24 2019, 3:14 PM

Owners added a subscriber: Restricted Owners Package.Jul 24 2019, 3:14 PM

Harbormaster completed remote builds in B23188: Diff 49321.Jul 24 2019, 3:16 PM

epriestley requested review of this revision.Jul 24 2019, 3:16 PM

amckinley accepted this revision.Jul 24 2019, 3:43 PM

This revision is now accepted and ready to land.Jul 24 2019, 3:43 PM

Closed by commit rPf6621a5fdcff: Tailor "Restart All Builds" for the complex realities of modern build restart… (authored by epriestley). · Explain WhyJul 24 2019, 4:25 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPf6621a5fdcff: Tailor "Restart All Builds" for the complex realities of modern build restart….

jmeador awarded a token.Jul 24 2019, 5:11 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

controller/

HarbormasterBuildableActionController.php

155 lines

HarbormasterBuildableViewController.php

8 lines

Diff 49321

View Options

src/applications/harbormaster/controller/HarbormasterBuildableActionController.php