Page MenuHomePhabricator

Tailor "Restart All Builds" for the complex realities of modern build restart rules
ClosedPublic

Authored by epriestley on Jul 24 2019, 3:14 PM.

Details

Summary

Fixes T13348. Currently, the Harbormaster UI shows "Restart All Builds", but it really means "Restart Restartable Builds", which is often fewer than "All" builds (because of autobuilds, permissions, and/or configuration).

Remove the misleading term "All" and make the workflow preview exactly which builds will and will not be affected, and why.

Test Plan

Screen Shot 2019-07-24 at 8.11.41 AM.png (785×1 px, 162 KB)

Screen Shot 2019-07-24 at 8.11.10 AM.png (762×1 px, 173 KB)

Screen Shot 2019-07-24 at 8.11.02 AM.png (762×1 px, 172 KB)

Diff Detail

Repository
rP Phabricator
Branch
restart1
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 23188
Build 31849: Run Core Tests
Build 31848: arc lint + arc unit