Page MenuHomePhabricator
Differential D20679

Tailor "Restart All Builds" for the complex realities of modern build restart rules
ClosedPublic
Actions

Authored by epriestley on Jul 24 2019, 3:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 3:18 AM
Unknown Object (File)
Fri, Apr 19, 3:18 AM
Unknown Object (File)
Fri, Apr 19, 3:18 AM
Unknown Object (File)
Thu, Apr 11, 10:52 AM
Unknown Object (File)
Thu, Apr 11, 4:28 AM
Unknown Object (File)
Mon, Apr 1, 10:11 PM
Unknown Object (File)
Mon, Apr 1, 10:11 PM
Unknown Object (File)
Mon, Apr 1, 10:09 PM
View All Files
Subscribers
Restricted Owners Package
Tokens
"Y So Serious" token, awarded by jmeador.

Details

Reviewers
amckinley
Maniphest Tasks
T13348: "Restart All Builds" is misleading in the presence of non-restartable builds
Commits
rPf6621a5fdcff: Tailor "Restart All Builds" for the complex realities of modern build restart…
Summary

Fixes T13348. Currently, the Harbormaster UI shows "Restart All Builds", but it really means "Restart Restartable Builds", which is often fewer than "All" builds (because of autobuilds, permissions, and/or configuration).

Remove the misleading term "All" and make the workflow preview exactly which builds will and will not be affected, and why.

Test Plan

Screen Shot 2019-07-24 at 8.11.41 AM.png (785×1 px, 162 KB)

Screen Shot 2019-07-24 at 8.11.10 AM.png (762×1 px, 173 KB)

Screen Shot 2019-07-24 at 8.11.02 AM.png (762×1 px, 172 KB)

Diff Detail

Repository
rP Phabricator
Branch
restart1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 23188
Build 31849: Run Core Tests
Build 31848: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
harbormaster/
controller/
155 lines
8 lines

Diff 49321

View Options

src/applications/harbormaster/controller/HarbormasterBuildableActionController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildableViewController.php

Loading...
Phabricator · Built by Phacility