Page MenuHomePhabricator

Tailor "Restart All Builds" for the complex realities of modern build restart rules
ClosedPublic

Authored by epriestley on Jul 24 2019, 3:14 PM.
Tags
None
Referenced Files
F12811256: D20679.diff
Wed, Mar 27, 11:03 PM
Unknown Object (File)
Thu, Mar 14, 5:38 PM
Unknown Object (File)
Mon, Mar 4, 10:34 PM
Unknown Object (File)
Feb 22 2024, 3:35 PM
Unknown Object (File)
Feb 19 2024, 9:51 PM
Unknown Object (File)
Feb 10 2024, 7:29 AM
Unknown Object (File)
Feb 7 2024, 6:41 PM
Unknown Object (File)
Feb 3 2024, 11:00 PM
Subscribers
Restricted Owners Package
Tokens
"Y So Serious" token, awarded by jmeador.

Details

Summary

Fixes T13348. Currently, the Harbormaster UI shows "Restart All Builds", but it really means "Restart Restartable Builds", which is often fewer than "All" builds (because of autobuilds, permissions, and/or configuration).

Remove the misleading term "All" and make the workflow preview exactly which builds will and will not be affected, and why.

Test Plan

Screen Shot 2019-07-24 at 8.11.41 AM.png (785×1 px, 162 KB)

Screen Shot 2019-07-24 at 8.11.10 AM.png (762×1 px, 173 KB)

Screen Shot 2019-07-24 at 8.11.02 AM.png (762×1 px, 172 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable