Page MenuHomePhabricator

When triggering audits, respect committer identities when importing commits
ClosedPublic

Authored by epriestley on Jun 17 2019, 5:04 PM.
Tags
None
Referenced Files
F13207355: D20580.diff
Wed, May 15, 10:20 PM
F13192314: D20580.diff
Sun, May 12, 6:47 AM
F13176493: D20580.id.diff
Wed, May 8, 2:26 PM
Unknown Object (File)
Thu, May 2, 3:21 PM
Unknown Object (File)
Thu, Apr 25, 12:00 AM
Unknown Object (File)
Wed, Apr 24, 3:53 AM
Unknown Object (File)
Sat, Apr 20, 11:14 PM
Unknown Object (File)
Apr 19 2024, 5:20 AM
Subscribers
None

Details

Summary

Ref T13311. We currently don't use committer identity mappings when triggering audits, so if a user is only associated with an identity via manual mapping we won't treat them as the author.

Instead, use the identity and manual mapping if they're available.

Test Plan
  • Pushed a commit as xyz <xyz@example.org>, an address with no corresponding user.
  • In the UI, manually associated that identity with user @alice.
  • Ran bin/repository reparse --publish <hash> to trigger audits and publishing for the commit.
  • Before: observed the $author_phid was null.
  • After: observed the $author_phid is Alice.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable