Page MenuHomePhabricator

When triggering audits, respect committer identities when importing commits
ClosedPublic

Authored by epriestley on Jun 17 2019, 5:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 3:32 PM
Unknown Object (File)
Thu, Apr 11, 8:17 AM
Unknown Object (File)
Sun, Apr 7, 8:25 AM
Unknown Object (File)
Mar 14 2024, 5:29 PM
Unknown Object (File)
Mar 1 2024, 5:27 PM
Unknown Object (File)
Jan 16 2024, 12:08 AM
Unknown Object (File)
Dec 26 2023, 9:08 PM
Unknown Object (File)
Dec 25 2023, 8:15 PM
Subscribers
None

Details

Summary

Ref T13311. We currently don't use committer identity mappings when triggering audits, so if a user is only associated with an identity via manual mapping we won't treat them as the author.

Instead, use the identity and manual mapping if they're available.

Test Plan
  • Pushed a commit as xyz <xyz@example.org>, an address with no corresponding user.
  • In the UI, manually associated that identity with user @alice.
  • Ran bin/repository reparse --publish <hash> to trigger audits and publishing for the commit.
  • Before: observed the $author_phid was null.
  • After: observed the $author_phid is Alice.

Diff Detail

Repository
rP Phabricator
Branch
audit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22960
Build 31510: Run Core Tests
Build 31509: arc lint + arc unit