Page MenuHomePhabricator

When triggering audits, respect committer identities when importing commits
ClosedPublic

Authored by epriestley on Jun 17 2019, 5:04 PM.
Tags
None
Referenced Files
F15469565: D20580.id49085.diff
Fri, Apr 4, 2:43 PM
F15468806: D20580.id49099.diff
Fri, Apr 4, 6:12 AM
F15468650: D20580.diff
Fri, Apr 4, 3:33 AM
F15425304: D20580.id.diff
Sun, Mar 23, 3:57 AM
F15422180: D20580.id49085.diff
Sat, Mar 22, 6:21 AM
Unknown Object (File)
Feb 9 2025, 7:52 AM
Unknown Object (File)
Feb 9 2025, 7:52 AM
Unknown Object (File)
Feb 9 2025, 7:52 AM
Subscribers
None

Details

Summary

Ref T13311. We currently don't use committer identity mappings when triggering audits, so if a user is only associated with an identity via manual mapping we won't treat them as the author.

Instead, use the identity and manual mapping if they're available.

Test Plan
  • Pushed a commit as xyz <xyz@example.org>, an address with no corresponding user.
  • In the UI, manually associated that identity with user @alice.
  • Ran bin/repository reparse --publish <hash> to trigger audits and publishing for the commit.
  • Before: observed the $author_phid was null.
  • After: observed the $author_phid is Alice.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable