Page MenuHomePhabricator

When triggering audits, respect committer identities when importing commits
ClosedPublic

Authored by epriestley on Jun 17 2019, 5:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 6:07 PM
Unknown Object (File)
Sat, Nov 16, 11:27 AM
Unknown Object (File)
Tue, Nov 12, 3:32 AM
Unknown Object (File)
Thu, Nov 7, 6:54 PM
Unknown Object (File)
Sun, Nov 3, 3:51 AM
Unknown Object (File)
Wed, Oct 30, 12:50 PM
Unknown Object (File)
Oct 22 2024, 5:19 AM
Unknown Object (File)
Oct 4 2024, 2:51 AM
Subscribers
None

Details

Summary

Ref T13311. We currently don't use committer identity mappings when triggering audits, so if a user is only associated with an identity via manual mapping we won't treat them as the author.

Instead, use the identity and manual mapping if they're available.

Test Plan
  • Pushed a commit as xyz <xyz@example.org>, an address with no corresponding user.
  • In the UI, manually associated that identity with user @alice.
  • Ran bin/repository reparse --publish <hash> to trigger audits and publishing for the commit.
  • Before: observed the $author_phid was null.
  • After: observed the $author_phid is Alice.

Diff Detail

Repository
rP Phabricator
Branch
audit1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22960
Build 31510: Run Core Tests
Build 31509: arc lint + arc unit