Page MenuHomePhabricator

Really fix movable panels inside tab panels by changing the JX.Request serializer
ClosedPublic

Authored by epriestley on Apr 25 2019, 7:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 25, 11:32 AM
Unknown Object (File)
Tue, Feb 25, 11:32 AM
Unknown Object (File)
Fri, Feb 14, 10:53 PM
Unknown Object (File)
Fri, Feb 14, 10:53 PM
Unknown Object (File)
Fri, Feb 14, 10:53 PM
Unknown Object (File)
Fri, Feb 14, 10:52 PM
Unknown Object (File)
Sun, Feb 9, 7:43 AM
Unknown Object (File)
Sun, Feb 9, 7:43 AM
Subscribers
None

Details

Summary

Depends on D20475. Ref T13272. Currently, if you JX.Request with data like {x: null}, we submit that as ?x=null, i.e. as though null was the string "null".

This is weird and almost certainly never intended/desiarable. In particular, it causes a bug where panels embedded inside tab panels are incorrectly draggable.

It's possible this breaks something which relied on the buggy behavior, but that seems unlikely.

Test Plan

Tried to drag a panel inside a tab panel, it really truly didn't work.

Diff Detail

Repository
rP Phabricator
Branch
panel5
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 22723
Build 31148: Run Core Tests
Build 31147: arc lint + arc unit