Page MenuHomePhabricator

Really fix movable panels inside tab panels by changing the JX.Request serializer
ClosedPublic

Authored by epriestley on Apr 25 2019, 7:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 24, 7:20 AM
Unknown Object (File)
Tue, Mar 19, 3:27 PM
Unknown Object (File)
Tue, Mar 19, 3:26 PM
Unknown Object (File)
Tue, Mar 19, 3:26 PM
Unknown Object (File)
Tue, Mar 19, 3:26 PM
Unknown Object (File)
Jan 25 2024, 2:04 AM
Unknown Object (File)
Jan 23 2024, 11:03 AM
Unknown Object (File)
Dec 29 2023, 1:00 PM
Subscribers
None

Details

Summary

Depends on D20475. Ref T13272. Currently, if you JX.Request with data like {x: null}, we submit that as ?x=null, i.e. as though null was the string "null".

This is weird and almost certainly never intended/desiarable. In particular, it causes a bug where panels embedded inside tab panels are incorrectly draggable.

It's possible this breaks something which relied on the buggy behavior, but that seems unlikely.

Test Plan

Tried to drag a panel inside a tab panel, it really truly didn't work.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable