Page MenuHomePhabricator
Differential D20439

Support drawing multiple functions on the same chart
ClosedPublic
Actions

Authored by epriestley on Apr 17 2019, 2:01 AM.
Tags
None
Referenced Files
F15485766: D20439.diff
Thu, Apr 10, 2:11 AM
F15455783: D20439.id48794.diff
Sun, Mar 30, 4:50 AM
F15453317: D20439.id48744.diff
Sat, Mar 29, 10:52 AM
F15441777: D20439.id.diff
Wed, Mar 26, 7:50 PM
F15435896: D20439.diff
Tue, Mar 25, 10:47 AM
F15422051: D20439.id48744.diff
Sat, Mar 22, 5:01 AM
F15418107: D20439.diff
Thu, Mar 20, 8:53 PM
Unknown Object (File)
Mar 3 2025, 6:35 AM
View All Files
Subscribers
yelirekim

Details

Reviewers
amckinley
Maniphest Tasks
T13279: Build Charting for Facts
Commits
rP044c6fbc19d4: Support drawing multiple functions on the same chart
Summary

Depends on D20438. Ref T13279. Widgets produced vs widgets sold, etc.

Test Plan

Screen Shot 2019-04-16 at 6.59.47 PM.png (1×1 px, 228 KB)

Diff Detail

Repository
rP Phabricator
Branch
chart3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22614
Build 30991: Run Core Tests
Build 30990: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 17 2019, 2:01 AM
Herald added a subscriber: yelirekim. · View Herald TranscriptApr 17 2019, 2:01 AM
Harbormaster completed remote builds in B22614: Diff 48744.Apr 17 2019, 2:03 AM
epriestley requested review of this revision.Apr 17 2019, 2:03 AM
epriestley added a child revision: D20440: Fetch chart data via async request and redraw charts when the window is resized.Apr 17 2019, 2:31 AM
amckinley accepted this revision.Apr 17 2019, 10:15 PM
amckinley added inline comments.
src/applications/fact/controller/PhabricatorFactChartController.php
67

Not sure if removing this is in the rest of your stack, or if you meant to remove it here.

This revision is now accepted and ready to land.Apr 17 2019, 10:15 PM
epriestley added inline comments.Apr 18 2019, 2:07 PM
src/applications/fact/controller/PhabricatorFactChartController.php
67

I'm updating the Controller bit by bit as a sort of demo of what goofy looking sine wave the code is currently drawing.

Closed by commit rP044c6fbc19d4: Support drawing multiple functions on the same chart (authored by epriestley). · Explain WhyApr 18 2019, 2:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
fact/
controller/
66 lines
webroot/
rsrc/
js/
application/
maniphest/
95 lines

Diff 48744

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/fact/controller/PhabricatorFactChartController.php

Loading...
View Options

webroot/rsrc/js/application/maniphest/behavior-line-chart.js

Loading...
Phabricator · Built by Phacility