Page MenuHomePhabricator

During first-time setup, create an administrator account with no authentication instead of weird, detached authentication
ClosedPublic

Authored by epriestley on Feb 6 2019, 11:33 PM.
Tags
None
Referenced Files
F13345690: D20111.diff
Fri, Jun 21, 11:13 AM
F13343733: D20111.diff
Fri, Jun 21, 5:10 AM
F13337202: D20111.diff
Wed, Jun 19, 9:17 AM
F13324641: D20111.diff
Sat, Jun 15, 12:50 AM
F13312016: D20111.diff
Tue, Jun 11, 6:01 AM
F13297654: D20111.diff
Fri, Jun 7, 5:48 AM
F13296877: D20111.id48127.diff
Thu, Jun 6, 9:10 PM
F13291668: D20111.id48020.diff
Wed, Jun 5, 12:09 AM
Subscribers

Details

Summary

Ref T6703. Currently, when you create an account on a new install, we prompt you to select a password.

You can't actually use that password unless you set up a password provider, and that password can't be associated with a provider since a password provider won't exist yet.

Instead, just don't ask for a password: create an account with a username and an email address only. Setup guidance points you toward Auth.

If you lose the session, you can send yourself an email link (if email works yet) or bin/auth recover it. This isn't really much different than the pre-change behavior, since you can't use the password you set anyway until you configure password auth.

This also makes fixing T9512 more important, which I'll do in a followup. I also plan to add slightly better guideposts toward Auth.

Test Plan

Hit first-time setup, created an account.

Diff Detail

Repository
rP Phabricator
Branch
welcome14
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/auth/controller/PhabricatorAuthRegisterController.php:46XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 21860
Build 29833: Run Core Tests
Build 29832: arc lint + arc unit