Page MenuHomePhabricator

During first-time setup, create an administrator account with no authentication instead of weird, detached authentication
ClosedPublic

Authored by epriestley on Feb 6 2019, 11:33 PM.
Tags
None
Referenced Files
F15467909: D20111.id48127.diff
Thu, Apr 3, 6:19 PM
F15466659: D20111.id48020.diff
Thu, Apr 3, 8:02 AM
F15441708: D20111.diff
Wed, Mar 26, 7:30 PM
F15440621: D20111.id48127.diff
Wed, Mar 26, 1:51 PM
F15438032: D20111.id.diff
Tue, Mar 25, 10:53 PM
F15429564: D20111.diff
Mon, Mar 24, 2:57 AM
F15408468: D20111.id.diff
Tue, Mar 18, 11:18 PM
F15389707: D20111.id48127.diff
Sat, Mar 15, 5:35 AM
Subscribers

Details

Summary

Ref T6703. Currently, when you create an account on a new install, we prompt you to select a password.

You can't actually use that password unless you set up a password provider, and that password can't be associated with a provider since a password provider won't exist yet.

Instead, just don't ask for a password: create an account with a username and an email address only. Setup guidance points you toward Auth.

If you lose the session, you can send yourself an email link (if email works yet) or bin/auth recover it. This isn't really much different than the pre-change behavior, since you can't use the password you set anyway until you configure password auth.

This also makes fixing T9512 more important, which I'll do in a followup. I also plan to add slightly better guideposts toward Auth.

Test Plan

Hit first-time setup, created an account.

Diff Detail

Repository
rP Phabricator
Branch
welcome14
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/auth/controller/PhabricatorAuthRegisterController.php:46XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 21860
Build 29833: Run Core Tests
Build 29832: arc lint + arc unit