Page MenuHomePhabricator
Differential D20037

Replace "Show Secret" in Passphrase with one-shot MFA
ClosedPublic
Actions

Authored by epriestley on Jan 25 2019, 6:23 PM.
Tags
None
Referenced Files
F15473679: D20037.diff
Sun, Apr 6, 12:36 AM
F15470041: D20037.id.diff
Fri, Apr 4, 7:08 PM
F15468203: D20037.diff
Thu, Apr 3, 9:34 PM
F15450021: D20037.diff
Fri, Mar 28, 1:30 PM
F15389074: D20037.id47846.diff
Sat, Mar 15, 4:52 AM
F15367914: D20037.id47866.diff
Tue, Mar 11, 10:01 PM
F15337750: D20037.id.diff
Sun, Mar 9, 7:33 AM
F15285724: D20037.diff
Mar 4 2025, 3:41 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13222: 2018 Week 48-51 Bonus Content
Commits
rP44a0b3e83d90: Replace "Show Secret" in Passphrase with one-shot MFA
Summary

Depends on D20036. Ref T13222. Now that we support one-shot MFA, swap this from session MFA to one-shot MFA.

Test Plan

Revealed a credential, was no longer left in high-security mode.

Diff Detail

Repository
rP Phabricator
Branch
mfa7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21700
Build 29601: Run Core Tests
Build 29600: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
passphrase/
controller/
9 lines
storage/
4 lines
xaction/
6 lines

Diff 47846

View Options

src/applications/passphrase/controller/PassphraseCredentialRevealController.php

Loading...
View Options

src/applications/passphrase/storage/PassphraseCredential.php

Loading...
View Options

src/applications/passphrase/xaction/PassphraseCredentialLookedAtTransaction.php

Loading...
Phabricator · Built by Phacility